linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <shinya.kuribayashi-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
To: baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org,
	ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 10/22] i2c-designware: Set Tx/Rx FIFO threshold levels
Date: Fri, 06 Nov 2009 21:48:12 +0900	[thread overview]
Message-ID: <4AF41B0C.2080604@necel.com> (raw)
In-Reply-To: <4AF419B6.1000802-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>

As a hardware feature, DW I2C core generates a STOP condition whenever
the Tx FIFO becomes empty (strictly speaking, whenever the last byte in
the Tx FIFO is sent out), even if we have more bytes to be written.

In other words, we must never make "Tx FIFO underrun" happen during
a transaction, except for the last byte.  For the safety's sake, we'd
make TX_EMPTY interrupt get triggered every time one byte is processed.

The Rx FIFO threshold needs to be set as well.

Signed-off-by: Shinya Kuribayashi <shinya.kuribayashi-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
Acked-by: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
---
 drivers/i2c/busses/i2c-designware.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-designware.c b/drivers/i2c/busses/i2c-designware.c
index 5fce1a0..0eea0dd 100644
--- a/drivers/i2c/busses/i2c-designware.c
+++ b/drivers/i2c/busses/i2c-designware.c
@@ -50,6 +50,8 @@
 #define DW_IC_INTR_STAT		0x2c
 #define DW_IC_INTR_MASK		0x30
 #define DW_IC_RAW_INTR_STAT	0x34
+#define DW_IC_RX_TL		0x38
+#define DW_IC_TX_TL		0x3c
 #define DW_IC_CLR_INTR		0x40
 #define DW_IC_CLR_RX_UNDER	0x44
 #define DW_IC_CLR_RX_OVER	0x48
@@ -295,6 +297,10 @@ static void i2c_dw_init(struct dw_i2c_dev *dev)
 	writel(lcnt, dev->base + DW_IC_FS_SCL_LCNT);
 	dev_dbg(dev->dev, "Fast-mode HCNT:LCNT = %d:%d\n", hcnt, lcnt);
 
+	/* Configure Tx/Rx FIFO threshold levels */
+	writel(dev->tx_fifo_depth - 1, dev->base + DW_IC_TX_TL);
+	writel(0, dev->base + DW_IC_RX_TL);
+
 	/* configure the i2c master */
 	ic_con = DW_IC_CON_MASTER | DW_IC_CON_SLAVE_DISABLE |
 		DW_IC_CON_RESTART_EN | DW_IC_CON_SPEED_FAST;
-- 
1.6.5.2

  parent reply	other threads:[~2009-11-06 12:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-06 12:42 [PATCH v2] i2c-designware updates Shinya Kuribayashi
     [not found] ` <4AF419B6.1000802-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
2009-11-06 12:43   ` [PATCH v2 01/22] i2c-designware: Consolidate to use 32-bit word accesses Shinya Kuribayashi
2009-11-06 12:44   ` [PATCH v2 02/22] i2c-designware: Don't use the IC_CLR_INTR register to clear interrupts Shinya Kuribayashi
2009-11-06 12:45   ` [PATCH v2 03/22] i2c-designware: Use platform_get_irq helper Shinya Kuribayashi
2009-11-06 12:45   ` [PATCH v2 04/22] i2c-designware: i2c_dw_read: Use "struct dw_i2c_dev" pointer Shinya Kuribayashi
2009-11-06 12:46   ` [PATCH v2 05/22] i2c-designware: i2c_dw_xfer_msg: " Shinya Kuribayashi
2009-11-06 12:46   ` [PATCH v2 06/22] i2c-designware: Remove an useless local variable "num" Shinya Kuribayashi
2009-11-06 12:47   ` [PATCH v2 07/22] i2c-designware: Improved _HCNT/_LCNT calculation Shinya Kuribayashi
2009-11-06 12:47   ` [PATCH v2 08/22] i2c-designware: i2c_dw_xfer_msg: Fix i2c_msg search bug Shinya Kuribayashi
2009-11-06 12:47   ` [PATCH v2 09/22] i2c-designware: Process i2c_msg messages in the interrupt handler Shinya Kuribayashi
2009-11-06 12:48   ` Shinya Kuribayashi [this message]
2009-11-06 12:48   ` [PATCH v2 11/22] i2c-designware: Enable RX_FULL interrupt Shinya Kuribayashi
2009-11-06 12:48   ` [PATCH v2 12/22] i2c-designware: Divide i2c_dw_xfer_msg into two functions Shinya Kuribayashi
2009-11-06 12:49   ` [PATCH v2 13/22] i2c-designware: i2c_dw_xfer_msg: Introduce a local "buf" pointer Shinya Kuribayashi
2009-11-06 12:49   ` [PATCH v2 14/22] i2c-designware: Initialize byte count variables just prior to being used Shinya Kuribayashi
2009-11-06 12:50   ` [PATCH v2 15/22] i2c-designware: i2c_dw_func: Set I2C_FUNC_SMBUS_foo bits Shinya Kuribayashi
2009-11-06 12:50   ` [PATCH v2 16/22] i2c-designware: i2c_dw_read: Remove redundant target address checker Shinya Kuribayashi
2009-11-06 12:50   ` [PATCH v2 17/22] i2c-designware: Process all i2c_msg messages in the interrupt handler Shinya Kuribayashi
2009-11-06 12:51   ` [PATCH v2 18/22] i2c-designware: Disable TX_EMPTY when all i2c_msg msgs has been processed Shinya Kuribayashi
2009-11-06 12:51   ` [PATCH v2 19/22] i2c-designware: i2c_dw_xfer_msg: Fix error handling procedures Shinya Kuribayashi
2009-11-06 12:51   ` [PATCH v2 20/22] i2c-designware: Skip RX_FULL and TX_EMPTY bits on tx abort errors Shinya Kuribayashi
2009-11-06 12:51   ` [PATCH v2 21/22] i2c-designware: Tx abort cleanups Shinya Kuribayashi
     [not found]     ` <4AF41BED.1050406-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
2009-11-12  4:29       ` Shinya Kuribayashi
     [not found]         ` <4AFB8F3A.6060208-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
2009-11-14 22:22           ` Ben Dooks
     [not found]             ` <20091114222249.GM13398-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-11-16 11:27               ` Shinya Kuribayashi
2009-11-06 12:52   ` [PATCH v2 22/22] i2c-designware: Cosmetic cleanups Shinya Kuribayashi
2009-11-06 22:25   ` [PATCH v2] i2c-designware updates Ben Dooks
2009-11-16 11:40   ` [PATCH 23/22] i2c-designware: i2c_dw_handle_tx_abort: Use dev_dbg() for NOACK cases Shinya Kuribayashi
2009-11-23 23:11   ` [PATCH v2] i2c-designware updates Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF41B0C.2080604@necel.com \
    --to=shinya.kuribayashi-jawzhaxaiamavxtiumwx3w@public.gmane.org \
    --cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).