From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>,
wd-ynQEQJNshbs@public.gmane.org,
dzu-ynQEQJNshbs@public.gmane.org,
linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Piotr Ziecik <kosmo-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support
Date: Fri, 22 Jan 2010 13:15:24 +0100 [thread overview]
Message-ID: <4B5996DC.1020309@grandegger.com> (raw)
In-Reply-To: <fa686aa41001210912r5fd2a5a4g8a072e0c41ee4107-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Grant Likely wrote:
> On Tue, Jan 19, 2010 at 1:24 PM, Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org> wrote:
>> From: Piotr Ziecik <kosmo-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
>>
>> - Update Kconfig for i2c-mpc driver.
>> - Enable I2C interrupts on MPC5121.
>>
>> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
>> index f627001..84eeb25 100644
>> --- a/drivers/i2c/busses/i2c-mpc.c
>> +++ b/drivers/i2c/busses/i2c-mpc.c
>> @@ -540,6 +540,29 @@ static int __devinit fsl_i2c_probe(struct of_device *op,
>> }
>> }
>>
>> + if (of_device_is_compatible(op->node, "fsl,mpc5121-i2c")) {
>
> Rather than doing stuff like this with explicit compatible checks in
> the probe hook, consider using the .data pointer in the of match
> table.
Yes, and it does also not use the clock setting code of the MPC5200,
which should work for the MPC512x as well. I already have a patch in my
pipeline, which I will roll out after some more testing.
Wolfgang.
next prev parent reply other threads:[~2010-01-22 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 20:24 [PATCH 0/11] Update support for MPC512x Anatolij Gustschin
[not found] ` <1263932653-3634-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2010-01-19 20:24 ` [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support Anatolij Gustschin
[not found] ` <1263932653-3634-5-git-send-email-agust-ynQEQJNshbs@public.gmane.org>
2010-01-21 17:12 ` Grant Likely
[not found] ` <fa686aa41001210912r5fd2a5a4g8a072e0c41ee4107-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-22 12:15 ` Wolfgang Grandegger [this message]
2010-01-20 11:22 ` [PATCH 0/11] Update support for MPC512x Wolfram Sang
[not found] ` <20100120112232.GD5041-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-01-26 8:06 ` Anatolij Gustschin
2010-01-26 12:16 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5996DC.1020309@grandegger.com \
--to=wg-5yr1bzd7o62+xt7jha+gda@public.gmane.org \
--cc=agust-ynQEQJNshbs@public.gmane.org \
--cc=dzu-ynQEQJNshbs@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=kosmo-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
--cc=wd-ynQEQJNshbs@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).