* [PATCH] tsc2007 : set irq edge
@ 2010-02-24 10:34 Matthieu CASTET
[not found] ` <4B85009D.3040604-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Matthieu CASTET @ 2010-02-24 10:34 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Kwangwoo Lee
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
Hi,
We need to pass a trigger flag for the interruption to work with some
gpio controller.
This patch make it work on a arm omap chip.
Signed-off-by: Matthieu CASTET <matthieu.castet-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: tsc2007_irq.diff --]
[-- Type: text/x-diff, Size: 560 bytes --]
diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
index 7ef0d14..a16b9e5 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -312,7 +312,7 @@ static int __devinit tsc2007_probe(struct i2c_client *client,
if (pdata->init_platform_hw)
pdata->init_platform_hw();
- err = request_irq(ts->irq, tsc2007_irq, 0,
+ err = request_irq(ts->irq, tsc2007_irq, IRQF_TRIGGER_FALLING,
client->dev.driver->name, ts);
if (err < 0) {
dev_err(&client->dev, "irq %d busy?\n", ts->irq);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tsc2007 : set irq edge
[not found] ` <4B85009D.3040604-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
@ 2010-02-24 14:38 ` Matthieu CASTET
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu CASTET @ 2010-02-24 14:38 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: linux-input-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
Matthieu CASTET a écrit :
> Hi,
>
> We need to pass a trigger flag for the interruption to work with some
> gpio controller.
>
> This patch make it work on a arm omap chip.
>
> Signed-off-by: Matthieu CASTET <matthieu.castet-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
>
in fact we should trigger on low level.
The problem with falling edge is that we trigger irq when sending
command to chip even if there are disable : there are resend on irq_enable!
Signed-off-by: Matthieu CASTET <matthieu.castet-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: tsc2007_irq.diff --]
[-- Type: text/x-diff, Size: 556 bytes --]
diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
index 7ef0d14..a16b9e5 100644
--- a/drivers/input/touchscreen/tsc2007.c
+++ b/drivers/input/touchscreen/tsc2007.c
@@ -312,7 +312,7 @@ static int __devinit tsc2007_probe(struct i2c_client *client,
if (pdata->init_platform_hw)
pdata->init_platform_hw();
- err = request_irq(ts->irq, tsc2007_irq, 0,
+ err = request_irq(ts->irq, tsc2007_irq, IRQF_TRIGGER_LOW,
client->dev.driver->name, ts);
if (err < 0) {
dev_err(&client->dev, "irq %d busy?\n", ts->irq);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-24 14:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-24 10:34 [PATCH] tsc2007 : set irq edge Matthieu CASTET
[not found] ` <4B85009D.3040604-ITF29qwbsa/QT0dZR+AlfA@public.gmane.org>
2010-02-24 14:38 ` Matthieu CASTET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).