From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH v6] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt Date: Wed, 28 Apr 2010 05:22:59 -0500 Message-ID: <4BD80C83.8080903@ti.com> References: <1272433677-28658-1-git-send-email-manjugk@ti.com> <4BD80867.7020801@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-omap-owner@vger.kernel.org To: "G, Manjunath Kondaiah" Cc: "linux-omap@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "ben-linux@fluff.org" , "Kalliguddi, Hema" , Aaro Koskinen , Tony Lindgren List-Id: linux-i2c@vger.kernel.org On 04/28/2010 05:20 AM, G, Manjunath Kondaiah wrote: [..] >>> >>> + dev->errata = 0; >>> + >>> + if (cpu_is_omap2430() || cpu_is_omap34xx()) >> ^^^^^^^^ wont cpu_is_omap24xx() cover omap2420 as >> well? I think it might be better using that.. apologies on >> missing it in >> the last look. > > This errata is not applicable for 2420 and it is applicable for: > 1. omap2430 > 2. omap34xx(including omap3630). > > Sorry. My earlier patch was using this errata logic for all omap's > except omap4 which was wrong(for omap2420 and omap1 - not sure, I don't have > any data hence ignoring this errata for omap1 also). > Could you fix your commit message to state so instead of using OMAP2? thanks.. I think we are almost close to the final rev is Tony is ok as well.. Thanks for hanging in there.. [...] Regards, Nishanth Menon