From: Ryan Mallon <ryan@bluewatersys.com>
To: Robert Emanuele <rob@emanuele.us>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
Linus Walleij <linus.ml.walleij@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-i2c@vger.kernel.org
Subject: Re: Controlling Driver Load Order
Date: Fri, 28 May 2010 09:09:01 +1200 [thread overview]
Message-ID: <4BFEDF6D.3090100@bluewatersys.com> (raw)
In-Reply-To: <AANLkTilKUfcYsPqr5kXlONJQAFCaE8D8U9ltQybIzCPu@mail.gmail.com>
Robert Emanuele wrote:
> Hi Wolfram,
>
> I am using the i2c-gpio.c driver, not the i2c-at91 driver. The Atmel
> folks have expressed concerns over their i2c silicon and wrote a gpio
> version.
>
> Anyway, I better understand the subsys_initcall now and applied that
> to the i2c-gpio and my i2c chip driver. That worked perfectly for my
> issue. I'd be happy to return a patch of this. Would be this the
> sort of thing that would benefit from a config option? Something
> like:
>
> #if defined(CONFIG_EARLY_i2C_GPIO)
> subsys_initcall(i2c_gpio_init);
> #else
> module_init(i2c_gpio_init);
> #endif
Looks like this has already been done:
http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg03056.html
There was a discussion a while back to make all of the embedded i2c
busses be subsys_initcall since i2c is often a system bus on embedded
devices. Looks the i2c_gpio driver got missed the first time round.
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2010-05-27 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTikzDvWakd7JW3DzTHinjS3dAlqzPx6K8V2qMDG7@mail.gmail.com>
[not found] ` <AANLkTinkY8JYh44UOEPflBUDyQ2wat_AKShRjA3HPxrf@mail.gmail.com>
[not found] ` <20100526235246.GA31068@pengutronix.de>
[not found] ` <AANLkTikj8yGSK5Ovud_k8f6jWloojqDJmQ_H6pD_IFgM@mail.gmail.com>
2010-05-27 4:13 ` Controlling Driver Load Order Wolfram Sang
[not found] ` <20100527041358.GA14070-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-27 17:07 ` Robert Emanuele
2010-05-27 21:01 ` Wolfram Sang
2010-05-27 21:09 ` Ryan Mallon [this message]
2010-05-27 21:42 ` Wolfram Sang
[not found] ` <20100527214209.GC5636-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-05-27 21:54 ` Ryan Mallon
[not found] ` <4BFEEA08.70401-7Wk5F4Od5/oYd5yxfr4S2w@public.gmane.org>
2010-05-27 22:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFEDF6D.3090100@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@emanuele.us \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).