From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH] i2c: Enable i2c-s3c2410 for S5P cpus Date: Thu, 03 Jun 2010 19:27:24 +0900 Message-ID: <4C07838C.2060201@samsung.com> References: <1275544623-5425-1-git-send-email-jy0922.shim@samsung.com> <20100603084603.GB4720@trinity.fluff.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7BIT Return-path: In-reply-to: <20100603084603.GB4720-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ben Dooks Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: linux-i2c@vger.kernel.org On 6/3/2010 5:46 PM, Ben Dooks wrote: > On Thu, Jun 03, 2010 at 02:57:03PM +0900, Joonyoung Shim wrote: >> This i2c controller driver can be used on the S5P series processors too, >> so enable the driver in Konfig for those platforms. >> >> Signed-off-by: Joonyoung Shim >> Signed-off-by: Kyungmin Park >> --- >> drivers/i2c/busses/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 87ab056..4765d62 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -503,7 +503,7 @@ config I2C_PXA_SLAVE >> >> config I2C_S3C2410 >> tristate "S3C2410 I2C Driver" >> - depends on ARCH_S3C2410 || ARCH_S3C64XX >> + depends on ARCH_S3C2410 || ARCH_S3C64XX || PLAT_S5P > > It may be worth changing this to PLAT_S3C24XX || ARCH_S3C64XX || PLAT_S5P > or maybe we should just enable it if PLAT_SAMSUNG > I think PLAT_SAMSUNG is more appropriate thing if it is no problem. > It would be good to get an policy sorted out on these core drivers which > exists across many parts of S3C/S5P supported systems. >