From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used Date: Mon, 14 Jun 2010 20:56:44 -0700 Message-ID: <4C16F9FC.2080905@gmail.com> References: <1276547208-26569-1-git-send-email-justinmattock@gmail.com> <1276547208-26569-5-git-send-email-justinmattock@gmail.com> <21331.1276560832@localhost> <4C16E18F.9050901@gmail.com> <9275.1276573789@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9275.1276573789@localhost> Sender: linux-kernel-owner@vger.kernel.org To: Valdis.Kletnieks@vt.edu Cc: linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-bluetooth@vger.kernel.org, clemens@ladisch.de, debora@linux.vnet.ibm.com, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org List-Id: linux-i2c@vger.kernel.org On 06/14/2010 08:49 PM, Valdis.Kletnieks@vt.edu wrote: > On Mon, 14 Jun 2010 19:12:31 PDT, "Justin P. Mattock" said: > >> what I tried was this: >> >> if (!rc) >> printk("test........"\n") >> >> and everything looked good, >> but as a soon as I changed >> >> rc = transmit_cmd(chip,&tpm_cmd, TPM_INTERNAL_RESULT_SIZE, >> "attempting to determine the timeouts"); >> >> to this: >> >> rc = transmit_cmd(chip,&tpm_cmd, TPM_INTERNAL_RESULT_SIZE); >> >> if (!rc) >> printk("attempting to determine the timeouts\n"); > > *baffled* Why did you think that would work? transmit_cmd()s signature > has 4 parameters. I have no manual in front of me. Did a quick google, but came up with (no hits) info on what that function does. grep showed too many entries to really see why/what this is. So I kind of just scrambled with this one. Justin P. Mattock