From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH] i2c: Drop dummy variable Date: Wed, 16 Jun 2010 08:48:11 -0700 Message-ID: <4C18F23B.5080202@gmail.com> References: <20100616164147.43bf4fbe@hyperion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100616164147.43bf4fbe-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare Cc: Linux I2C , David Daney List-Id: linux-i2c@vger.kernel.org On 06/16/2010 07:41 AM, Jean Delvare wrote: > Now that bus_for_each_drv() is no longer __must_check, we can drop the > dummy variable that was used to store the returned value. > > Signed-off-by: Jean Delvare > Cc: Justin P. Mattock > --- > Anticipating that my other patch will be accepted... > > drivers/i2c/i2c-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > --- linux-2.6.35-rc3.orig/drivers/i2c/i2c-core.c 2010-06-16 12:44:52.000000000 +0200 > +++ linux-2.6.35-rc3/drivers/i2c/i2c-core.c 2010-06-16 12:44:54.000000000 +0200 > @@ -783,7 +783,7 @@ static int __process_new_adapter(struct > > static int i2c_register_adapter(struct i2c_adapter *adap) > { > - int res = 0, dummy; > + int res = 0; > > /* Can't register until after driver model init */ > if (unlikely(WARN_ON(!i2c_bus_type.p))) { > @@ -821,8 +821,7 @@ static int i2c_register_adapter(struct i > > /* Notify drivers */ > mutex_lock(&core_lock); > - dummy = bus_for_each_drv(&i2c_bus_type, NULL, adap, > - __process_new_adapter); > + bus_for_each_drv(&i2c_bus_type, NULL, adap, __process_new_adapter); > mutex_unlock(&core_lock); > > return 0; > > cool thanks!! applied the above patch and now the warning is no longer there. Here is what I see: LD kernel/built-in.o CC drivers/i2c/i2c-core.o LD drivers/i2c/built-in.o CC [M] drivers/uio/uio.o cheers, Justin P. Mattock