From: Trilok Soni <tsoni-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Gregory Bean <gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver.
Date: Mon, 12 Jul 2010 14:25:24 +0530 [thread overview]
Message-ID: <4C3AD87C.1010407@codeaurora.org> (raw)
In-Reply-To: <4C370EB4.4040906-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Hi Jean, Andrew,
On 7/9/2010 5:27 PM, Trilok Soni wrote:
> On 7/9/2010 1:07 AM, Gregory Bean wrote:
>> Add support for Semtech SX150-series I2C GPIO expanders.
>> Compatible models include:
>>
>> 8 bits: sx1508q
>> 16 bits: sx1509q
>>
>> Signed-off-by: Gregory Bean <gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> ---
>> drivers/gpio/Kconfig | 11 +
>> drivers/gpio/Makefile | 1 +
>> drivers/gpio/sx150x.c | 646 ++++++++++++++++++++++++++++++++++++++++++++
>> include/linux/i2c/sx150x.h | 78 ++++++
>> 4 files changed, 736 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/gpio/sx150x.c
>> create mode 100644 include/linux/i2c/sx150x.h
>>
>
> Looks good to me.
>
> Reviewed-by: Trilok Soni <tsoni-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>
Any review comments on this new version of the driver?
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-07-12 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 19:37 [PATCH v2] gpio: sx150x: Add Semtech I2C sx150x gpio expander driver Gregory Bean
[not found] ` <1278617834-14970-1-git-send-email-gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2010-07-09 11:57 ` Trilok Soni
[not found] ` <4C370EB4.4040906-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2010-07-12 8:55 ` Trilok Soni [this message]
[not found] ` <4C3AD87C.1010407-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2010-07-12 23:46 ` Andrew Morton
2010-07-19 23:31 ` Andrew Morton
[not found] ` <20100719163142.16cab271.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-07-19 23:50 ` Andrew Morton
[not found] ` <20100719165038.a308b019.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2010-07-20 9:25 ` Mark Brown
2010-07-20 8:21 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3AD87C.1010407@codeaurora.org \
--to=tsoni-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=gbean-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).