From: Ben Dooks <ben@simtec.co.uk>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Naveen Krishna Ch <ch.naveen@samsung.com>,
linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs
Date: Wed, 04 Aug 2010 16:03:13 +0100 [thread overview]
Message-ID: <4C598131.3050705@simtec.co.uk> (raw)
In-Reply-To: <AANLkTikyOUyz+sNPgBvWU8FvYa8HvgRY4P2udhMY=eOw@mail.gmail.com>
On 30/07/10 01:22, Kyungmin Park wrote:
> On Thu, Jul 29, 2010 at 6:42 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> From: Naveen Krishna Ch <ch.naveen@samsung.com>
>>
>> This patch adds HAVE_S3C2410_I2C to control inclusion of I2C bus driver
>> on Samsung SoCs and makes I2C bus driver dependency SoC specific instead
>> of machine specific. This will enalbe all machines using Samsung ARCH_S3C2410,
>> _S3C64XX, _S5P6440, _S5PC100, and _S5PV210 to select the I2C driver by default
>
> What's the different from use PLAT_SAMSUNG?
>
> config I2C_S3C2410
> tristate "S3C2410 I2C Driver"
> depends on PLAT_SAMSUNG
>
> Please don't populate the Kconfigs.
For things that are pretty common among all the Samsung architectures
such as the i2c, rtc and serial ports that we use PLAT_SAMSUNG, as these
drivers tend to compile and do not go wrong when loaded onto newer
systems (either the device name is changed, so if there is no support
then the driver will not bind, or someone didn't change the name in the
soc support and it should only be a transitory bug during development).
I'm going to spend some time thinking about the current Kconfig setup
to see if there is any improvements can be done.
--
Ben
prev parent reply other threads:[~2010-08-04 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 9:42 [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs Kukjin Kim
2010-07-30 0:22 ` Kyungmin Park
2010-07-30 1:03 ` Kukjin Kim
2010-07-30 2:42 ` Kyungmin Park
2010-07-30 4:25 ` Kukjin Kim
2010-08-04 15:03 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C598131.3050705@simtec.co.uk \
--to=ben@simtec.co.uk \
--cc=ben-linux@fluff.org \
--cc=ch.naveen@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).