From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Brandewie Subject: Re: [PATCH 02/10] i2c-designware: split of i2c-designware.c into core and bus specific parts Date: Tue, 08 Feb 2011 08:20:24 -0800 Message-ID: <4D516D48.6000104@gmail.com> References: <1296699608-13227-1-git-send-email-dirk.brandewie@gmail.com> <1296699608-13227-3-git-send-email-dirk.brandewie@gmail.com> <20110205174507.GH15795@trinity.fluff.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110205174507.GH15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ben Dooks Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alan.cox-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, shinya.kuribayashi.px-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org List-Id: linux-i2c@vger.kernel.org On 02/05/2011 09:45 AM, Ben Dooks wrote: > On Wed, Feb 02, 2011 at 06:20:00PM -0800, dirk.brandewie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >> From: Dirk Brandewie >> >> This patch splits i2c-designware.c into a core library and associated >> header file and two bus specific parts for platform bus and PCI bus. > > not a library, it is a driver card. > >> Signed-off-by: Dirk Brandewie >> --- >> drivers/i2c/busses/Kconfig | 15 +- >> drivers/i2c/busses/Makefile | 5 +- >> drivers/i2c/busses/i2c-designware-core.c | 563 +++++++++++++++++ >> drivers/i2c/busses/i2c-designware-core.h | 194 ++++++ >> drivers/i2c/busses/i2c-designware-pcidrv.c | 199 ++++++ >> drivers/i2c/busses/i2c-designware-platdrv.c | 199 ++++++ >> drivers/i2c/busses/i2c-designware.c | 884 --------------------------- >> 7 files changed, 1171 insertions(+), 888 deletions(-) >> create mode 100644 drivers/i2c/busses/i2c-designware-core.c >> create mode 100644 drivers/i2c/busses/i2c-designware-core.h >> create mode 100644 drivers/i2c/busses/i2c-designware-pcidrv.c >> create mode 100644 drivers/i2c/busses/i2c-designware-platdrv.c >> delete mode 100644 drivers/i2c/busses/i2c-designware.c > > what happens when you use 'rename' detection when submitting? > drivers/i2c/busses/Kconfig | 25 +- drivers/i2c/busses/Makefile | 6 +- .../{i2c-designware.c => i2c-designware-core.c} | 496 +++------- drivers/i2c/busses/i2c-designware-core.h | 203 ++++ drivers/i2c/busses/i2c-designware-pcidrv.c | 395 +++++++ drivers/i2c/busses/i2c-designware-platdrv.c | 209 ++++ drivers/i2c/busses/i2c-intel-mid.c | 1135 -------------------- I will make sure to have rename detection on in the futute >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 113505a..a815606 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -347,15 +347,24 @@ config I2C_DAVINCI >> devices such as DaVinci NIC. >> For details please see http://www.ti.com/davinci >> >> -config I2C_DESIGNWARE >> - tristate "Synopsys DesignWare" >> +config I2C_DESIGNWARE_PLATFORM >> + tristate "Synopsys DesignWare Platfrom" >> depends on HAVE_CLK >> help >> If you say yes to this option, support will be included for the >> Synopsys DesignWare I2C adapter. Only master mode is supported. >> >> This driver can also be built as a module. If so, the module >> - will be called i2c-designware. >> + will be called i2c-designware-platform. > > not so happy about change in module name. > I am open to any name, the current names come from Shinya's feedback. I will use what ever name everyone finds reasonable.