From: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
To: Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
Cc: anish singh
<anish198519851985-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
gregkh-l3A5Bk7waGM@public.gmane.org,
manuel.stahl-GeUHRtUQU7nSyEMIgutvibNAH6kLmebB@public.gmane.org,
lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] staging iio: Replace kmalloc with local variable
Date: Thu, 09 Jun 2011 11:46:35 +0100 [thread overview]
Message-ID: <4DF0A48B.6040802@cam.ac.uk> (raw)
In-Reply-To: <4DF088E5.5000408-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
On 06/09/11 09:48, Jonathan Cameron wrote:
> On 06/09/11 09:34, anish singh wrote:
>>
>>
>> On Thu, Jun 9, 2011 at 1:59 PM, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <mailto:khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>> wrote:
>>
>> On Thu, 9 Jun 2011 13:53:09 +0530, anish singh wrote:
>> > On Wed, Jun 8, 2011 at 10:41 AM, anish singh <anish198519851985-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org <mailto:anish198519851985-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>>wrote:
>> > > On Tue, Jun 7, 2011 at 7:32 PM, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <mailto:khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>> wrote:
>> > >> To be clearer, it is down to the i2c BUS (adapter) driver, NOT the i2c
>> > >> device driver. So the patch is correct.
>> > >>
>> > > I think i can take Jean ack on this?If yes then Joanthan kindly apply
>> > > this patch and i think you didn't lead me in wrong way as whatever
>> > > said by you is corroborated by jean also i.e. it is I2C bus driver
>> > > responsiblity
>> > > to care about DMA.
>> > >
>> > Sorry to ping you again.Can i take your ack on this?
>>
>> Yes of course.
>>
>> Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org <mailto:khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>>
>>
>> Thanks a ton.Jonathan kindly apply it now :)
> Greg, I'll send this one on to you with the set I currently have out for review.
>
Doh, after all this, I just tried to apply this to find the code in question has already
gone. Anish, what tree are you working against? Looks like I did an equivalent clean up
(with a load of others) back in May then forgot about it.
Sorry all. I should have actually have checked it was still relevant rather than reviewing
purely on basis of content of patch...
Jonathan
next prev parent reply other threads:[~2011-06-09 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1307450354.1516.23.camel@anish-desktop>
2011-06-07 13:00 ` [PATCH] staging iio: Replace kmalloc with local variable Jonathan Cameron
[not found] ` <4DEE20E7.4020008-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2011-06-07 13:41 ` Ben Dooks
[not found] ` <20110607134135.GD15795-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2011-06-07 13:54 ` Jonathan Cameron
[not found] ` <4DEE2D7D.6070506-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2011-06-07 14:04 ` Hennerich, Michael
2011-06-07 14:02 ` Jean Delvare
[not found] ` <BANLkTim5-ZKXtDkSQyHAJ9-iKtOPsJ917A@mail.gmail.com>
[not found] ` <BANLkTi=e0A2G-d+t4VF5V0gj+eNoh3KRnQ@mail.gmail.com>
[not found] ` <BANLkTi=e0A2G-d+t4VF5V0gj+eNoh3KRnQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-09 8:29 ` Jean Delvare
[not found] ` <BANLkTimq_5rmB+UkaxZwrOtV-ZF3+fEOgQ@mail.gmail.com>
[not found] ` <BANLkTimq_5rmB+UkaxZwrOtV-ZF3+fEOgQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-09 8:48 ` Jonathan Cameron
[not found] ` <4DF088E5.5000408-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>
2011-06-09 10:46 ` Jonathan Cameron [this message]
[not found] ` <BANLkTik4Tfd73iKcDsXK-sfy6_ADVX4oYA@mail.gmail.com>
[not found] ` <BANLkTik4Tfd73iKcDsXK-sfy6_ADVX4oYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-06-09 14:51 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF0A48B.6040802@cam.ac.uk \
--to=jic23-kwpb1pkirijaa/9udqfwiw@public.gmane.org \
--cc=anish198519851985-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org \
--cc=gregkh-l3A5Bk7waGM@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org \
--cc=manuel.stahl-GeUHRtUQU7nSyEMIgutvibNAH6kLmebB@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).