From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH] staging iio: Replace kmalloc with local variable Date: Thu, 09 Jun 2011 11:46:35 +0100 Message-ID: <4DF0A48B.6040802@cam.ac.uk> References: <1307450354.1516.23.camel@anish-desktop> <4DEE20E7.4020008@cam.ac.uk> <20110607134135.GD15795@trinity.fluff.org> <20110607160206.6cb3168d@endymion.delvare> <20110609102948.7a3f8d57@endymion.delvare> <4DF088E5.5000408@cam.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4DF088E5.5000408-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jonathan Cameron Cc: anish singh , Jean Delvare , Ben Dooks , gregkh-l3A5Bk7waGM@public.gmane.org, manuel.stahl-GeUHRtUQU7nSyEMIgutvibNAH6kLmebB@public.gmane.org, lucas.demarchi-Y3ZbgMPKUGA34EUeqzHoZw@public.gmane.org, devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux I2C List-Id: linux-i2c@vger.kernel.org On 06/09/11 09:48, Jonathan Cameron wrote: > On 06/09/11 09:34, anish singh wrote: >> >> >> On Thu, Jun 9, 2011 at 1:59 PM, Jean Delvare > wrote: >> >> On Thu, 9 Jun 2011 13:53:09 +0530, anish singh wrote: >> > On Wed, Jun 8, 2011 at 10:41 AM, anish singh >wrote: >> > > On Tue, Jun 7, 2011 at 7:32 PM, Jean Delvare > wrote: >> > >> To be clearer, it is down to the i2c BUS (adapter) driver, NOT the i2c >> > >> device driver. So the patch is correct. >> > >> >> > > I think i can take Jean ack on this?If yes then Joanthan kindly apply >> > > this patch and i think you didn't lead me in wrong way as whatever >> > > said by you is corroborated by jean also i.e. it is I2C bus driver >> > > responsiblity >> > > to care about DMA. >> > > >> > Sorry to ping you again.Can i take your ack on this? >> >> Yes of course. >> >> Acked-by: Jean Delvare > >> >> Thanks a ton.Jonathan kindly apply it now :) > Greg, I'll send this one on to you with the set I currently have out for review. > Doh, after all this, I just tried to apply this to find the code in question has already gone. Anish, what tree are you working against? Looks like I did an equivalent clean up (with a load of others) back in May then forgot about it. Sorry all. I should have actually have checked it was still relevant rather than reviewing purely on basis of content of patch... Jonathan