* [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore
@ 2011-07-15 6:01 Shubhrajyoti D
[not found] ` <1310709714-3295-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Shubhrajyoti D @ 2011-07-15 6:01 UTC (permalink / raw)
To: linux-omap-u79uwXL29TY76Z2rM5mHXA
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, khilman-l0cyMroinI0,
Shubhrajyoti D
Restore of context is not done for OMAP4. This patch
adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
hwmod data which activates the restore for OMAP4.
Currently the OMAP4 does not hit device off still the
driver may have support for it.
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 0fe9556..5e2c748 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
};
static struct omap_i2c_dev_attr i2c_dev_attr = {
- .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+ .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+ OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
};
/* i2c1 */
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread[parent not found: <1310709714-3295-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore [not found] ` <1310709714-3295-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> @ 2011-07-15 21:55 ` Kevin Hilman [not found] ` <871uxrnr92.fsf-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Kevin Hilman @ 2011-07-15 21:55 UTC (permalink / raw) To: Shubhrajyoti D Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> writes: > Restore of context is not done for OMAP4. This patch > adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 > hwmod data which activates the restore for OMAP4. > Currently the OMAP4 does not hit device off still the > driver may have support for it. > > Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> Reviewed-by: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org> Please repost one more time with the linux-arm-kernel list Cc'd (and you can add my reviewed-by tag.) Paul can then probably queue this for v3.1-rc Kevin > --- > Applies on top of patches from Andy Green > http://www.spinics.net/lists/linux-i2c/msg05632.html > Tested on OMAP4430 > > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > index 0fe9556..5e2c748 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = { > }; > > static struct omap_i2c_dev_attr i2c_dev_attr = { > - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE, > + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE | > + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE, > }; > > /* i2c1 */ ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <871uxrnr92.fsf-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore [not found] ` <871uxrnr92.fsf-l0cyMroinI0@public.gmane.org> @ 2011-07-17 15:33 ` Shubhrajyoti 0 siblings, 0 replies; 7+ messages in thread From: Shubhrajyoti @ 2011-07-17 15:33 UTC (permalink / raw) To: Kevin Hilman Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA On Saturday 16 July 2011 03:25 AM, Kevin Hilman wrote: > Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org> writes: > >> Restore of context is not done for OMAP4. This patch >> adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 >> hwmod data which activates the restore for OMAP4. >> Currently the OMAP4 does not hit device off still the >> driver may have support for it. >> >> Signed-off-by: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org> > Reviewed-by: Kevin Hilman<khilman-l0cyMroinI0@public.gmane.org> > > Please repost one more time with the linux-arm-kernel list Cc'd (and you > can add my reviewed-by tag.) > > Paul can then probably queue this for v3.1-rc > > Kevin OK thanks >> --- >> Applies on top of patches from Andy Green >> http://www.spinics.net/lists/linux-i2c/msg05632.html >> Tested on OMAP4430 >> >> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> index 0fe9556..5e2c748 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = { >> }; >> >> static struct omap_i2c_dev_attr i2c_dev_attr = { >> - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE, >> + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE | >> + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE, >> }; >> >> /* i2c1 */ ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore
@ 2011-07-17 12:43 Shubhrajyoti D
[not found] ` <1310906603-2673-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Shubhrajyoti D @ 2011-07-17 12:43 UTC (permalink / raw)
To: linux-omap-u79uwXL29TY76Z2rM5mHXA
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
khilman-l0cyMroinI0, Shubhrajyoti D
Restore of context is not done for OMAP4. This patch
adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4
hwmod data which activates the restore for OMAP4.
Currently the OMAP4 does not hit device off still the
driver may have support for it.
Reviewed-by: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
Applies on top of patches from Andy Green
http://www.spinics.net/lists/linux-i2c/msg05632.html
Tested on OMAP4430
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
index 0fe9556..5e2c748 100644
--- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
@@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = {
};
static struct omap_i2c_dev_attr i2c_dev_attr = {
- .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE,
+ .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE |
+ OMAP_I2C_FLAG_RESET_REGS_POSTIDLE,
};
/* i2c1 */
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread[parent not found: <1310906603-2673-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore [not found] ` <1310906603-2673-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> @ 2011-08-24 10:18 ` Shubhrajyoti 2011-08-24 14:44 ` Kevin Hilman 0 siblings, 1 reply; 7+ messages in thread From: Shubhrajyoti @ 2011-08-24 10:18 UTC (permalink / raw) To: Shubhrajyoti D Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, khilman-l0cyMroinI0 On Sunday 17 July 2011 06:13 PM, Shubhrajyoti D wrote: > Restore of context is not done for OMAP4. This patch > adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 > hwmod data which activates the restore for OMAP4. > Currently the OMAP4 does not hit device off still the > driver may have support for it. Could this patch be queued as well? > Reviewed-by: Kevin Hilman<khilman-l0cyMroinI0@public.gmane.org> > Signed-off-by: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org> > --- > Applies on top of patches from Andy Green > http://www.spinics.net/lists/linux-i2c/msg05632.html > Tested on OMAP4430 > > arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > index 0fe9556..5e2c748 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c > @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = { > }; > > static struct omap_i2c_dev_attr i2c_dev_attr = { > - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE, > + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE | > + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE, > }; > > /* i2c1 */ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore 2011-08-24 10:18 ` Shubhrajyoti @ 2011-08-24 14:44 ` Kevin Hilman [not found] ` <87mxeyg98m.fsf-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Kevin Hilman @ 2011-08-24 14:44 UTC (permalink / raw) To: Shubhrajyoti; +Cc: linux-omap, linux-i2c, linux-arm-kernel Shubhrajyoti <shubhrajyoti@ti.com> writes: > On Sunday 17 July 2011 06:13 PM, Shubhrajyoti D wrote: >> Restore of context is not done for OMAP4. This patch >> adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 >> hwmod data which activates the restore for OMAP4. >> Currently the OMAP4 does not hit device off still the >> driver may have support for it. > Could this patch be queued as well? Paul is the maintainer for the hwmod data. It is usually helpful to ensure the maintainer is specifically added to the To line. Kevin >> Reviewed-by: Kevin Hilman<khilman@ti.com> >> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com> >> --- >> Applies on top of patches from Andy Green >> http://www.spinics.net/lists/linux-i2c/msg05632.html >> Tested on OMAP4430 >> >> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> index 0fe9556..5e2c748 100644 >> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >> @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = { >> }; >> >> static struct omap_i2c_dev_attr i2c_dev_attr = { >> - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE, >> + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE | >> + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE, >> }; >> >> /* i2c1 */ ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <87mxeyg98m.fsf-l0cyMroinI0@public.gmane.org>]
* Re: [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore [not found] ` <87mxeyg98m.fsf-l0cyMroinI0@public.gmane.org> @ 2011-08-25 12:22 ` Shubhrajyoti 0 siblings, 0 replies; 7+ messages in thread From: Shubhrajyoti @ 2011-08-25 12:22 UTC (permalink / raw) To: Kevin Hilman, paul-DWxLp4Yu+b8AvxtiuMwx3w Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-i2c-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wednesday 24 August 2011 08:14 PM, Kevin Hilman wrote: > Shubhrajyoti<shubhrajyoti-l0cyMroinI0@public.gmane.org> writes: > >> On Sunday 17 July 2011 06:13 PM, Shubhrajyoti D wrote: >>> Restore of context is not done for OMAP4. This patch >>> adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 >>> hwmod data which activates the restore for OMAP4. >>> Currently the OMAP4 does not hit device off still the >>> driver may have support for it. >> Could this patch be queued as well? > Paul is the maintainer for the hwmod data. It is usually helpful to > ensure the maintainer is specifically added to the To line. yes thanks will take care henceforth . For now adding him for comments. > Kevin > >>> Reviewed-by: Kevin Hilman<khilman-l0cyMroinI0@public.gmane.org> >>> Signed-off-by: Shubhrajyoti D<shubhrajyoti-l0cyMroinI0@public.gmane.org> >>> --- >>> Applies on top of patches from Andy Green >>> http://www.spinics.net/lists/linux-i2c/msg05632.html >>> Tested on OMAP4430 >>> >>> arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 3 ++- >>> 1 files changed, 2 insertions(+), 1 deletions(-) >>> >>> diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >>> index 0fe9556..5e2c748 100644 >>> --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >>> +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c >>> @@ -2130,7 +2130,8 @@ static struct omap_hwmod_class omap44xx_i2c_hwmod_class = { >>> }; >>> >>> static struct omap_i2c_dev_attr i2c_dev_attr = { >>> - .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE, >>> + .flags = OMAP_I2C_FLAG_BUS_SHIFT_NONE | >>> + OMAP_I2C_FLAG_RESET_REGS_POSTIDLE, >>> }; >>> >>> /* i2c1 */ ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-08-25 12:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-15 6:01 [PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore Shubhrajyoti D
[not found] ` <1310709714-3295-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-07-15 21:55 ` Kevin Hilman
[not found] ` <871uxrnr92.fsf-l0cyMroinI0@public.gmane.org>
2011-07-17 15:33 ` Shubhrajyoti
-- strict thread matches above, loose matches on Subject: below --
2011-07-17 12:43 Shubhrajyoti D
[not found] ` <1310906603-2673-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-08-24 10:18 ` Shubhrajyoti
2011-08-24 14:44 ` Kevin Hilman
[not found] ` <87mxeyg98m.fsf-l0cyMroinI0@public.gmane.org>
2011-08-25 12:22 ` Shubhrajyoti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).