linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Shubhrajyoti D <shubhrajyoti@ti.com>
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, khilman@ti.com,
	rnayak@ti.com, balajitk@ti.com
Subject: Re: [PATCHV2 1/5] OMAP: I2C: Add a device reset field to platform data
Date: Thu, 21 Jul 2011 16:48:11 +0530	[thread overview]
Message-ID: <4E280AF3.5000907@ti.com> (raw)
In-Reply-To: <1311246554-22975-2-git-send-email-shubhrajyoti@ti.com>

Shubro,

On 7/21/2011 4:39 PM, Shubhrajyoti D wrote:
> Under some conditions the driver may want to do a reset
> of the device. Adding a reset field  to the platform
> data.
>
> Signed-off-by: Shubhrajyoti D<shubhrajyoti@ti.com>
> ---
>   include/linux/i2c-omap.h |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/i2c-omap.h b/include/linux/i2c-omap.h
> index 98ae49b..8aa91b6 100644
> --- a/include/linux/i2c-omap.h
> +++ b/include/linux/i2c-omap.h
> @@ -38,6 +38,7 @@ struct omap_i2c_bus_platform_data {
>   	int		(*device_enable) (struct platform_device *pdev);
>   	int		(*device_shutdown) (struct platform_device *pdev);
>   	int		(*device_idle) (struct platform_device *pdev);
> +	int		(*device_reset) (struct device *dev);
Any reason you haven't clubbed this with the omap i2c reset
implementation patch ?
Since i2c-omap.h isn't a generic header file and specific
to omap i2c drive, you could combine 1/5 and 2/5



  reply	other threads:[~2011-07-21 11:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21 11:09 [PATCHV2 0/5] I2C: driver updates Shubhrajyoti D
2011-07-21 11:09 ` [PATCHV2 1/5] OMAP: I2C: Add a device reset field to platform data Shubhrajyoti D
2011-07-21 11:18   ` Santosh Shilimkar [this message]
     [not found] ` <1311246554-22975-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-07-21 11:09   ` [PATCHV2 2/5] OMAP: I2C: Reset support Shubhrajyoti D
2011-07-21 11:19     ` Santosh Shilimkar
2011-07-21 12:02       ` Shubhrajyoti
2011-07-21 11:09   ` [PATCHV2 3/5] OMAP: I2C: Remove the reset in the init path Shubhrajyoti D
     [not found]     ` <1311246554-22975-4-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-07-21 11:27       ` Santosh Shilimkar
2011-07-29 11:27         ` Shubhrajyoti
2011-07-21 11:09 ` [PATCHV2 4/5] OMAP: I2C: Remove the SYSC register definition Shubhrajyoti D
2011-07-21 11:28   ` Santosh Shilimkar
2011-07-21 11:09 ` [PATCHV2 5/5] OMAP: I2C: Restore only if context is lost Shubhrajyoti D
2011-07-21 11:30   ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E280AF3.5000907@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=balajitk@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).