From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH] dt: add empty of_get_property for non-dt Date: Sun, 07 Aug 2011 09:37:52 -0500 Message-ID: <4E3EA340.2010100@gmail.com> References: <1312584630-23371-1-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1312584630-23371-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Stephen Warren Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Colin Cross , Jean Delvare , Axel Lin , Ben Dooks List-Id: linux-i2c@vger.kernel.org On 08/05/2011 05:50 PM, Stephen Warren wrote: > The patch adds empty function of_get_property for non-dt build, so that > drivers migrating to dt can save some '#ifdef CONFIG_OF'. > > This also fixes the current Tegra compile problem in linux-next. > You could just use of_property_read_u32 in the driver. It already has empty version and will simplify the driver code some. Rob > Signed-off-by: Stephen Warren > --- > include/linux/of.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/include/linux/of.h b/include/linux/of.h > index 0085bb0..9180dc5 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -256,6 +256,13 @@ static inline int of_property_read_string(struct device_node *np, > return -ENOSYS; > } > > +static inline const void *of_get_property(const struct device_node *node, > + const char *name, > + int *lenp) > +{ > + return NULL; > +} > + > #endif /* CONFIG_OF */ > > static inline int of_property_read_u32(const struct device_node *np,