From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH V2] drivers/i2c/busses/i2c-at91.c: fix brokeness Date: Mon, 07 Nov 2011 13:49:04 +0100 Message-ID: <4EB7D3C0.9070706@atmel.com> References: <20111107094701.GF4265@legolas.emea.dhcp.ti.com> <20111107100446.GG4265@legolas.emea.dhcp.ti.com> <20111107130432.3309ffd6@endymion.delvare> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20111107130432.3309ffd6-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jean Delvare , "Voss, Nikolaus" , balbi-l0cyMroinI0@public.gmane.org Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks List-Id: linux-i2c@vger.kernel.org On 11/07/2011 01:04 PM, Jean Delvare : > On Mon, 7 Nov 2011 12:06:52 +0100, Voss, Nikolaus wrote: >>>>> IMHO, you should split this patch into three or more smaller patches. >>>>> You're doing lots of different things in one commit and it'll be a >>>>> pain to bisect should this cause any issues to anyone. >>>> >>>> I didn't split the patch because it is virtually a complete rewrite. >>>> Due to the severe limitations of the old driver, I think it should >>>> replace the old driver. >>> >>> The final decision is up to Ben and/or Jean but I think we should always have >>> incremental patches, not sure if we should allow big patches for the reasons >>> above. > > The final call is obviously to Ben, not me, as this driver falls under > his jurisdiction. But for what it's worth, I consider the small-steps > rule void when it comes to fixing a plain broken driver by almost fully > rewriting it. The reviewer should really review the resulting code > rather than the patch. If it makes everybody happier, then killing the > old code completely first is certainly an option. I agree with this. -- Nicolas Ferre