* [PATCH v3] OMAP: I2C: Fix the interrupt clearing in OMAP4
@ 2011-11-22 6:01 Shubhrajyoti D
[not found] ` <1321941716-4505-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Shubhrajyoti D @ 2011-11-22 6:01 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-omap, khilman, ben-linux, Shubhrajyoti D, Vikram Pandita
However on OMAP4 we were writing 1 to IRQENABLE_CLR which clears only
the arbitration lost interrupt. The patch intends to fix the same by writing
0 to the IE register.
Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/i2c/busses/i2c-omap.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 2dfb631..4220949 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -308,10 +308,8 @@ static void omap_i2c_idle(struct omap_i2c_dev *dev)
pdata = pdev->dev.platform_data;
dev->iestate = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
- if (dev->rev >= OMAP_I2C_REV_ON_4430)
- omap_i2c_write_reg(dev, OMAP_I2C_IRQENABLE_CLR, 1);
- else
- omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
+
+ omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
if (dev->rev < OMAP_I2C_REV_2) {
iv = omap_i2c_read_reg(dev, OMAP_I2C_IV_REG); /* Read clears */
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] OMAP: I2C: Fix the interrupt clearing in OMAP4
[not found] ` <1321941716-4505-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
@ 2011-11-22 6:07 ` Shubhrajyoti
0 siblings, 0 replies; 3+ messages in thread
From: Shubhrajyoti @ 2011-11-22 6:07 UTC (permalink / raw)
To: Shubhrajyoti D
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, khilman-l0cyMroinI0,
ben-linux-elnMNo+KYs3YtjvyW6yDsg, Vikram Pandita
On Tuesday 22 November 2011 11:31 AM, Shubhrajyoti D wrote:
> However on OMAP4 we were writing 1 to IRQENABLE_CLR which clears only
> the arbitration lost interrupt. The patch intends to fix the same by writing
> 0 to the IE register.
Please ignore this patch I will send another one in a while.
> Signed-off-by: Vikram Pandita <vikram.pandita-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-omap.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 2dfb631..4220949 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -308,10 +308,8 @@ static void omap_i2c_idle(struct omap_i2c_dev *dev)
> pdata = pdev->dev.platform_data;
>
> dev->iestate = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
> - if (dev->rev >= OMAP_I2C_REV_ON_4430)
> - omap_i2c_write_reg(dev, OMAP_I2C_IRQENABLE_CLR, 1);
> - else
> - omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
> +
> + omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
>
> if (dev->rev < OMAP_I2C_REV_2) {
> iv = omap_i2c_read_reg(dev, OMAP_I2C_IV_REG); /* Read clears */
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3] OMAP: I2C: Fix the interrupt clearing in OMAP4
@ 2011-11-28 13:53 Shubhrajyoti D
0 siblings, 0 replies; 3+ messages in thread
From: Shubhrajyoti D @ 2011-11-28 13:53 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, khilman-l0cyMroinI0,
ben-linux-elnMNo+KYs3YtjvyW6yDsg, Shubhrajyoti D, Vikram Pandita
On OMAP4 we were writing 1 to IRQENABLE_CLR which clears only
the arbitration lost interrupt however for other than OMAP4 we clear all the
interrupts at idle. The patch intends to fix the same by writing 0 to the
IE register.
Signed-off-by: Vikram Pandita <vikram.pandita-l0cyMroinI0@public.gmane.org>
Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
---
drivers/i2c/busses/i2c-omap.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index b6fcd08..0a139e7 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -306,10 +306,8 @@ static void omap_i2c_idle(struct omap_i2c_dev *dev)
pdata = pdev->dev.platform_data;
dev->iestate = omap_i2c_read_reg(dev, OMAP_I2C_IE_REG);
- if (dev->rev >= OMAP_I2C_REV_ON_4430)
- omap_i2c_write_reg(dev, OMAP_I2C_IRQENABLE_CLR, 1);
- else
- omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
+
+ omap_i2c_write_reg(dev, OMAP_I2C_IE_REG, 0);
if (dev->rev < OMAP_I2C_REV_2) {
iv = omap_i2c_read_reg(dev, OMAP_I2C_IV_REG); /* Read clears */
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-28 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 6:01 [PATCH v3] OMAP: I2C: Fix the interrupt clearing in OMAP4 Shubhrajyoti D
[not found] ` <1321941716-4505-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2011-11-22 6:07 ` Shubhrajyoti
-- strict thread matches above, loose matches on Subject: below --
2011-11-28 13:53 Shubhrajyoti D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).