From: Rajeev kumar <rajeev-dlh.kumar-qxv4g6HH51o@public.gmane.org>
To: Feng Tang <feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org"
<ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
"w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org"
<khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
"tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c-eg20t: use i2c_add_numbered_adapter to get a fixed bus number
Date: Thu, 12 Jan 2012 13:39:07 +0530 [thread overview]
Message-ID: <4F0E9523.1040709@st.com> (raw)
In-Reply-To: <1326353882-3158-1-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On 1/12/2012 1:08 PM, Feng Tang wrote:
> For EG20T and ML7213 IOH, the i2c controller numbers are fixed, using
> fixed bus number will make it much easier for platform code to use
> i2c_register_board_info() to register i2c devices.
>
> Signed-off-by: Feng Tang<feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-eg20t.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
> index 18936ac..079435b 100644
> --- a/drivers/i2c/busses/i2c-eg20t.c
> +++ b/drivers/i2c/busses/i2c-eg20t.c
> @@ -918,7 +918,9 @@ static int __devinit pch_i2c_probe(struct pci_dev *pdev,
> pch_adap->dev.parent =&pdev->dev;
>
> pch_i2c_init(&adap_info->pch_data[i]);
> - ret = i2c_add_adapter(pch_adap);
> +
> + pch_adap->nr = i;
> + ret = i2c_add_numbered_adapter(pch_adap);
> if (ret) {
> pch_pci_err(pdev, "i2c_add_adapter[ch:%d] FAILED\n", i);
> goto err_add_adapter;
Reviewd By: Rajeev Kumar <rajeev-dlh.kumar-qxv4g6HH51o@public.gmane.org>
prev parent reply other threads:[~2012-01-12 8:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 7:38 [PATCH] i2c-eg20t: use i2c_add_numbered_adapter to get a fixed bus number Feng Tang
[not found] ` <1326353882-3158-1-git-send-email-feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-01-12 8:09 ` Rajeev kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0E9523.1040709@st.com \
--to=rajeev-dlh.kumar-qxv4g6hh51o@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=feng.tang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tomoya.rohm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).