Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

[Sylwester Nawrocki <sylvester.nawrocki@gmail.com>]

On 01/21/2012 02:28 PM, Mark Brown wrote:
> Saves remembering to call kfree(). There's some kfree()s used by the
> resource still, these will be removed in 3.3 using the newly added
> devm_request_and_ioremap().
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

> ---
>   drivers/i2c/busses/i2c-s3c2410.c |    4 +---
>   1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 4c17180..e6f982b 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -890,7 +890,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>   		}
>   	}
> 
> -	i2c = kzalloc(sizeof(struct s3c24xx_i2c), GFP_KERNEL);
> +	i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL);
>   	if (!i2c) {
>   		dev_err(&pdev->dev, "no memory for state\n");
>   		return -ENOMEM;
> @@ -1035,7 +1035,6 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>   	clk_put(i2c->clk);
> 
>    err_noclk:
> -	kfree(i2c);
>   	return ret;
>   }
> 
> @@ -1061,7 +1060,6 @@ static int s3c24xx_i2c_remove(struct platform_device *pdev)
>   	release_resource(i2c->ioarea);
>   	s3c24xx_i2c_dt_gpio_free(i2c);
>   	kfree(i2c->ioarea);
> -	kfree(i2c);
> 
>   	return 0;
>   }

-- 

Thanks!
Sylwester