Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

[Sylwester Nawrocki <sylvester.nawrocki@gmail.com>]

On 01/21/2012 10:23 PM, Heiko Stübner wrote:
> Am Samstag 21 Januar 2012, 21:38:13 schrieb Sylwester Nawrocki:
>> On 01/21/2012 07:31 PM, Mark Brown wrote:
>>> On Sat, Jan 21, 2012 at 04:52:58PM +0100, Sylwester Nawrocki wrote:
>>>> On 01/21/2012 02:28 PM, Mark Brown wrote:
>>> that the rather serious problems with getting I2C patches applied I'd
>>> rather do as little as possible in individual patches.
>>>
>>> It would also introduce a regression for systems that don't use runtime
>>> PM (probably most s3c24xx ones).
>>
>> Indeed, I'd forgotten about this fact for a while. I suspect the Run-time
>> PM core functionality could be enabled on those platform, allowing to make
>> the common driver dependant on PM_RUNTIME. Not sure if that's acceptable
>> for the smaller SoCs though. It rather sounds more like lots of trouble
>> for little benefits. Maybe it's desirable to do that at some point anyway.
> 
> At least S3C2416/S3C2450 and S3C2412 (i.e. the ARMv5 SoCs) might profit from
> it, as they also support the idle modes (stop modes) that Mark is targetting
> with his patches in the long run.

Ah, I was just about to ask whether this patch is a part of some wider plan.
It would be much better to enable core runtime PM support on all platforms
that use particular driver, even though there is no any drivers adapted 
runtime PM on some of them yet.

> 
> Not sure about the 2410, 2440 and 2443 currently

But would just enabling RUNTIME_PM make any harm to those platforms ?

-- 

Regards,
Sylwester