* Re: [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 [not found] ` <4F36A2F2.7040003@ti.com> @ 2012-02-14 8:55 ` Tasslehoff Kjappfot 0 siblings, 0 replies; 6+ messages in thread From: Tasslehoff Kjappfot @ 2012-02-14 8:55 UTC (permalink / raw) To: linux-omap; +Cc: linux-i2c On 02/11/2012 06:18 PM, Shubhrajyoti wrote: > On Monday 06 February 2012 08:03 PM, tasskjapp@gmail.com wrote: >> From: Tasslehoff Kjappfot<tasskjapp@gmail.com> >> >> i2c_prope set the dev->errata flag, but omap_i2c_init cleared the flag again. Move the errata handling to i2c_init. >> > also in my opinion moving the reset to 0 should be moved to probe. Do you mean moving all setting of the errate flag to probe instead of having it in init? > also you may want to cc linux-i2c for the driver patches. Done. >> Signed-off-by: Tasslehoff Kjappfot<tasskjapp@gmail.com> >> --- >> drivers/i2c/busses/i2c-omap.c | 7 ++++--- >> 1 files changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c >> index 801df60..ecaa60d 100644 >> --- a/drivers/i2c/busses/i2c-omap.c >> +++ b/drivers/i2c/busses/i2c-omap.c >> @@ -473,6 +473,10 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) >> if (dev->flags& OMAP_I2C_FLAG_APPLY_ERRATA_I207) >> dev->errata |= I2C_OMAP_ERRATA_I207; >> >> + if (dev->rev<= OMAP_I2C_REV_ON_3430) >> + dev->errata |= I2C_OMAP3_1P153; >> + >> + >> /* Enable interrupts */ >> dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | >> OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | >> @@ -1058,9 +1062,6 @@ omap_i2c_probe(struct platform_device *pdev) >> >> dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG)& 0xff; >> >> - if (dev->rev<= OMAP_I2C_REV_ON_3430) >> - dev->errata |= I2C_OMAP3_1P153; >> - >> if (!(dev->flags& OMAP_I2C_FLAG_NO_FIFO)) { >> u16 s; >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1328538811-13097-1-git-send-email-tasskjapp-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 [not found] ` <1328538811-13097-1-git-send-email-tasskjapp-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2012-02-14 9:59 ` Tasslehoff Kjappfot 2012-02-14 10:15 ` [PATCH v2] " Tasslehoff Kjappfot 0 siblings, 1 reply; 6+ messages in thread From: Tasslehoff Kjappfot @ 2012-02-14 9:59 UTC (permalink / raw) To: linux-omap-u79uwXL29TY76Z2rM5mHXA Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Tasslehoff Kjappfot i2c_prope set the dev->errata flag, but omap_i2c_init cleared the flag again. Move the errata handling to i2c_probe. --- drivers/i2c/busses/i2c-omap.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 801df60..d609ae2 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -468,11 +468,6 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) /* Take the I2C module out of reset: */ omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN); - dev->errata = 0; - - if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) - dev->errata |= I2C_OMAP_ERRATA_I207; - /* Enable interrupts */ dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | @@ -1058,6 +1053,11 @@ omap_i2c_probe(struct platform_device *pdev) dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG) & 0xff; + dev->errata = 0; + + if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) + dev->errata |= I2C_OMAP_ERRATA_I207; + if (dev->rev <= OMAP_I2C_REV_ON_3430) dev->errata |= I2C_OMAP3_1P153; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] i2c: fix missing handling of errata I2C_OMAP3_1P153 2012-02-14 9:59 ` Tasslehoff Kjappfot @ 2012-02-14 10:15 ` Tasslehoff Kjappfot 2012-02-16 11:36 ` Shubhrajyoti Datta 0 siblings, 1 reply; 6+ messages in thread From: Tasslehoff Kjappfot @ 2012-02-14 10:15 UTC (permalink / raw) To: linux-omap, linux-i2c Sorry about the bad mails. First time I use git send-email to follow up on a patch, and it seems I need to read up a bit more on it. Anyway. This patch is tested on our custom board based on Beagleboard rev C3. From 7c1e2c14bccb16c20dc7d93088b12ac6e6e351a3 Mon Sep 17 00:00:00 2001 From: Tasslehoff Kjappfot <tasskjapp@gmail.com> Date: Mon, 6 Feb 2012 14:14:23 +0100 Subject: [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 i2c_prope set the dev->errata flag, but omap_i2c_init cleared the flag again. Move the errata handling to i2c_probe. Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com> --- drivers/i2c/busses/i2c-omap.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 801df60..d609ae2 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -468,11 +468,6 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) /* Take the I2C module out of reset: */ omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN); - dev->errata = 0; - - if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) - dev->errata |= I2C_OMAP_ERRATA_I207; - /* Enable interrupts */ dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | @@ -1058,6 +1053,11 @@ omap_i2c_probe(struct platform_device *pdev) dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG) & 0xff; + dev->errata = 0; + + if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) + dev->errata |= I2C_OMAP_ERRATA_I207; + if (dev->rev <= OMAP_I2C_REV_ON_3430) dev->errata |= I2C_OMAP3_1P153; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] i2c: fix missing handling of errata I2C_OMAP3_1P153 2012-02-14 10:15 ` [PATCH v2] " Tasslehoff Kjappfot @ 2012-02-16 11:36 ` Shubhrajyoti Datta 2012-02-17 12:19 ` [PATCH v3] " Tasslehoff Kjappfot 0 siblings, 1 reply; 6+ messages in thread From: Shubhrajyoti Datta @ 2012-02-16 11:36 UTC (permalink / raw) To: Tasslehoff Kjappfot; +Cc: linux-omap, linux-i2c Hi , On Tue, Feb 14, 2012 at 3:45 PM, Tasslehoff Kjappfot <tasskjapp@gmail.com> wrote: > Sorry about the bad mails. First time I use git send-email to follow up on a > patch, and it seems I need to read up a bit more on it. > > Anyway. > > This patch is tested on our custom board based on Beagleboard rev C3. thanks for the testing . may be include it in the changelogs . Just a suggestion not an objection to the patch. > > From 7c1e2c14bccb16c20dc7d93088b12ac6e6e351a3 Mon Sep 17 00:00:00 2001 > From: Tasslehoff Kjappfot <tasskjapp@gmail.com> > Date: Mon, 6 Feb 2012 14:14:23 +0100 > Subject: [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 > > > i2c_prope Nitpick : probe set the dev->errata flag, but omap_i2c_init cleared the flag > again. Move the errata handling to i2c_probe. > > Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com> > > --- > drivers/i2c/busses/i2c-omap.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 801df60..d609ae2 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -468,11 +468,6 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) > /* Take the I2C module out of reset: */ > omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN); > > - dev->errata = 0; > - > - if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) > - dev->errata |= I2C_OMAP_ERRATA_I207; > - > /* Enable interrupts */ > dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | > OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | > @@ -1058,6 +1053,11 @@ omap_i2c_probe(struct platform_device *pdev) > > dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG) & 0xff; > > + dev->errata = 0; > + > + if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) > + dev->errata |= I2C_OMAP_ERRATA_I207; > + > if (dev->rev <= OMAP_I2C_REV_ON_3430) > dev->errata |= I2C_OMAP3_1P153; > > -- > 1.7.5.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] i2c: fix missing handling of errata I2C_OMAP3_1P153 2012-02-16 11:36 ` Shubhrajyoti Datta @ 2012-02-17 12:19 ` Tasslehoff Kjappfot 2012-02-17 12:40 ` Shubhrajyoti Datta 0 siblings, 1 reply; 6+ messages in thread From: Tasslehoff Kjappfot @ 2012-02-17 12:19 UTC (permalink / raw) To: linux-omap; +Cc: linux-i2c From 0195dcf606b0ad069d8b5bc56cb877ff65ebea22 Mon Sep 17 00:00:00 2001 From: Tasslehoff Kjappfot <tasskjapp@gmail.com> Date: Mon, 6 Feb 2012 14:14:23 +0100 Subject: [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 i2c_probe set the dev->errata flag, but omap_i2c_init cleared the flag again. Move the errata handling to i2c_probe. Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com> --- drivers/i2c/busses/i2c-omap.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index 801df60..d609ae2 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -468,11 +468,6 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) /* Take the I2C module out of reset: */ omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN); - dev->errata = 0; - - if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) - dev->errata |= I2C_OMAP_ERRATA_I207; - /* Enable interrupts */ dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | @@ -1058,6 +1053,11 @@ omap_i2c_probe(struct platform_device *pdev) dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG) & 0xff; + dev->errata = 0; + + if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) + dev->errata |= I2C_OMAP_ERRATA_I207; + if (dev->rev <= OMAP_I2C_REV_ON_3430) dev->errata |= I2C_OMAP3_1P153; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] i2c: fix missing handling of errata I2C_OMAP3_1P153 2012-02-17 12:19 ` [PATCH v3] " Tasslehoff Kjappfot @ 2012-02-17 12:40 ` Shubhrajyoti Datta 0 siblings, 0 replies; 6+ messages in thread From: Shubhrajyoti Datta @ 2012-02-17 12:40 UTC (permalink / raw) To: Tasslehoff Kjappfot; +Cc: linux-omap, linux-i2c Hello, On Fri, Feb 17, 2012 at 5:49 PM, Tasslehoff Kjappfot <tasskjapp@gmail.com> wrote: > From 0195dcf606b0ad069d8b5bc56cb877ff65ebea22 Mon Sep 17 00:00:00 2001 > > From: Tasslehoff Kjappfot <tasskjapp@gmail.com> > Date: Mon, 6 Feb 2012 14:14:23 +0100 > Subject: [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 > > i2c_probe set the dev->errata flag, but omap_i2c_init cleared the flag > again. Move the errata handling to i2c_probe. > Looks good to me. Reviewed-by: Shubhrajyoti D <shubhrajyoti@ti.com> > > Signed-off-by: Tasslehoff Kjappfot <tasskjapp@gmail.com> > --- > drivers/i2c/busses/i2c-omap.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 801df60..d609ae2 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -468,11 +468,6 @@ static int omap_i2c_init(struct omap_i2c_dev *dev) > /* Take the I2C module out of reset: */ > omap_i2c_write_reg(dev, OMAP_I2C_CON_REG, OMAP_I2C_CON_EN); > > - dev->errata = 0; > - > - if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) > - dev->errata |= I2C_OMAP_ERRATA_I207; > - > /* Enable interrupts */ > dev->iestate = (OMAP_I2C_IE_XRDY | OMAP_I2C_IE_RRDY | > OMAP_I2C_IE_ARDY | OMAP_I2C_IE_NACK | > @@ -1058,6 +1053,11 @@ omap_i2c_probe(struct platform_device *pdev) > > dev->rev = omap_i2c_read_reg(dev, OMAP_I2C_REV_REG) & 0xff; > > + dev->errata = 0; > + > + if (dev->flags & OMAP_I2C_FLAG_APPLY_ERRATA_I207) > + dev->errata |= I2C_OMAP_ERRATA_I207; > + > if (dev->rev <= OMAP_I2C_REV_ON_3430) > dev->errata |= I2C_OMAP3_1P153; > > -- > 1.7.5.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-17 12:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1328538811-13097-1-git-send-email-tasskjapp@gmail.com>
[not found] ` <4F36A2F2.7040003@ti.com>
2012-02-14 8:55 ` [PATCH] i2c: fix missing handling of errata I2C_OMAP3_1P153 Tasslehoff Kjappfot
[not found] ` <1328538811-13097-1-git-send-email-tasskjapp-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-02-14 9:59 ` Tasslehoff Kjappfot
2012-02-14 10:15 ` [PATCH v2] " Tasslehoff Kjappfot
2012-02-16 11:36 ` Shubhrajyoti Datta
2012-02-17 12:19 ` [PATCH v3] " Tasslehoff Kjappfot
2012-02-17 12:40 ` Shubhrajyoti Datta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).