* eg20t i2c driver: missing some changes?
@ 2012-02-22 19:46 Richard Retanubun
0 siblings, 0 replies; only message in thread
From: Richard Retanubun @ 2012-02-22 19:46 UTC (permalink / raw)
To: tomoya-linux-8lRStDepK8iSL1NxhRU65dBPR1lH4CV8,
ben-linux-elnMNo+KYs3YtjvyW6yDsg
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Hi
I am using i2c-eg20t on linux 3.1.6 and comparing with the current source on 3.3-rc4
I think there is a (few) missing cleanup between the version pasted on:
http://www.spinics.net/lists/linux-i2c/msg06664.html
to the one in version 3.3-rc4
one of it is this change in pch_i2c_getack
@@ -348,7 +347,7 @@
reg_val = ioread32(p + PCH_I2CSR) & PCH_GETACK;
if (reg_val != 0) {
- pch_err(adap, "return%d\n", -EPROTO);
+ pch_dbg(adap, "return%d\n", -EPROTO);
return -EPROTO;
}
Without this change, using i2cdetect will generate a lot of false positive errors on devices that are not present.
I'm not sure if there is a patch that is missed or still being reviewed that contained this change
There are also some other differences between the mailing list version and linux-3.3rc4 in addition to this one,
but I don't have enough background to comment on them.
--
Richard Retanubun
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-02-22 19:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-22 19:46 eg20t i2c driver: missing some changes? Richard Retanubun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).