From: Viresh Kumar <viresh.kumar-qxv4g6HH51o@public.gmane.org>
To: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Cc: Pratyush ANAND <pratyush.anand-qxv4g6HH51o@public.gmane.org>,
"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org"
<baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
Armando VISCONTI <armando.visconti-qxv4g6HH51o@public.gmane.org>,
Shiraz HASHIM <shiraz.hashim-qxv4g6HH51o@public.gmane.org>,
Vipin KUMAR <vipin.kumar-qxv4g6HH51o@public.gmane.org>,
Rajeev KUMAR <rajeev-dlh.kumar-qxv4g6HH51o@public.gmane.org>,
Deepak SIKRI <deepak.sikri-qxv4g6HH51o@public.gmane.org>,
Vipul Kumar SAMAR <vipulkumar.samar-qxv4g6HH51o@public.gmane.org>,
Amit VIRDI <Amit.VIRDI-qxv4g6HH51o@public.gmane.org>,
Bhupesh SHARMA <bhupesh.sharma-qxv4g6HH51o@public.gmane.org>,
Bhavna YADAV <bhavna.yadav-qxv4g6HH51o@public.gmane.org>,
Vincenzo FRASCINO
<Vincenzo.FRASCINO-qxv4g6HH51o@public.gmane.org>,
Mirko GARDI <mirko.gardi-qxv4g6HH51o@public.gmane.org>
Subject: Re: [PATCH] i2c/designware: dw_i2c_init_driver as subsys initcall
Date: Mon, 27 Feb 2012 09:26:20 +0530 [thread overview]
Message-ID: <4F4AFEE4.5010401@st.com> (raw)
In-Reply-To: <1321419487-2353-1-git-send-email-pratyush.anand-qxv4g6HH51o@public.gmane.org>
On 11/16/2011 10:28 AM, Pratyush ANAND wrote:
> There are few drivers(for example stmpe-gpio) which are available on i2c
> bus but has been initialized as subsys initcall. Therefore i2c driver
> must also be initialized as subsys initcall.
>
> Signed-off-by: Pratyush Anand <pratyush.anand-qxv4g6HH51o@public.gmane.org>
> ---
> drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +-
> drivers/i2c/busses/i2c-designware-platdrv.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 9e89e73..7854565 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -379,7 +379,7 @@ static int __init dw_i2c_init_driver(void)
> {
> return pci_register_driver(&dw_i2c_driver);
> }
> -module_init(dw_i2c_init_driver);
> +subsys_initcall(dw_i2c_init_driver);
>
> static void __exit dw_i2c_exit_driver(void)
> {
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 2d3657a..4fbdcd5 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -202,7 +202,7 @@ static int __init dw_i2c_init_driver(void)
> {
> return platform_driver_probe(&dw_i2c_driver, dw_i2c_probe);
> }
> -module_init(dw_i2c_init_driver);
> +subsys_initcall(dw_i2c_init_driver);
>
> static void __exit dw_i2c_exit_driver(void)
> {
Hi Jean/Ben/Wolfram,
Can anyone of you apply this patch, if it looks fine.
--
viresh
next prev parent reply other threads:[~2012-02-27 3:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 4:58 [PATCH] i2c/designware: dw_i2c_init_driver as subsys initcall Pratyush Anand
[not found] ` <1321419487-2353-1-git-send-email-pratyush.anand-qxv4g6HH51o@public.gmane.org>
2011-11-16 5:14 ` Baruch Siach
[not found] ` <20111116051440.GA3142-MwjkAAnuF3khR1HGirfZ1z4kX+cae0hd@public.gmane.org>
2011-11-16 5:27 ` Shiraz Hashim
2011-11-16 8:22 ` Baruch Siach
[not found] ` <20111116082233.GB10335-MwjkAAnuF3khR1HGirfZ1z4kX+cae0hd@public.gmane.org>
2012-02-24 11:02 ` Viresh Kumar
[not found] ` <4F476E30.60807-qxv4g6HH51o@public.gmane.org>
2012-02-24 12:55 ` Baruch Siach
2012-02-27 3:56 ` Viresh Kumar [this message]
[not found] ` <4F4AFEE4.5010401-qxv4g6HH51o@public.gmane.org>
2012-02-27 13:17 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4AFEE4.5010401@st.com \
--to=viresh.kumar-qxv4g6hh51o@public.gmane.org \
--cc=Amit.VIRDI-qxv4g6HH51o@public.gmane.org \
--cc=Vincenzo.FRASCINO-qxv4g6HH51o@public.gmane.org \
--cc=armando.visconti-qxv4g6HH51o@public.gmane.org \
--cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=bhavna.yadav-qxv4g6HH51o@public.gmane.org \
--cc=bhupesh.sharma-qxv4g6HH51o@public.gmane.org \
--cc=deepak.sikri-qxv4g6HH51o@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mirko.gardi-qxv4g6HH51o@public.gmane.org \
--cc=pratyush.anand-qxv4g6HH51o@public.gmane.org \
--cc=rajeev-dlh.kumar-qxv4g6HH51o@public.gmane.org \
--cc=shiraz.hashim-qxv4g6HH51o@public.gmane.org \
--cc=vipin.kumar-qxv4g6HH51o@public.gmane.org \
--cc=vipulkumar.samar-qxv4g6HH51o@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).