From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 11/15] drivers/mfd: Enable Device Tree for ab8500-core driver Date: Wed, 09 May 2012 11:28:49 +0100 Message-ID: <4FAA46E1.4050708@linaro.org> References: <1336155805-18554-1-git-send-email-lee.jones@linaro.org> <1336155805-18554-12-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Mattias WALLIN List-Id: linux-i2c@vger.kernel.org On 09/05/12 10:02, Linus Walleij wrote: > On Fri, May 4, 2012 at 8:23 PM, Lee Jones wrot= e: > >> This patch will allow the ab8500-core driver to be probed and set up >> when booting when Device Tree is enabled. This includes platform ID >> look-up which identifies the machine it is currently running on. If >> we are undergoing a DT enabled boot, we will refuse to setup each of >> the other ab8500-* devices, as they will be probed individually by D= T. >> >> Signed-off-by: Lee Jones > (...) >> + else if (np) >> + ret =3D of_property_read_u32(np, "stericsson,irq-bas= e",&ab8500->irq_base); >> + >> + if (ab8500->irq_base =3D=3D 0) { > > Shouldn't this be (av8500->irq_base =3D=3D NO_IRQ) now that we're tra= nisitioning to > use 0 as NO_IRQ? Sure, why not. > Apart from that it looks good to me: > Acked-by: Linus Walleij --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog