From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V3 2/3] i2c-nomadik: turn the platform driver to an amba driver Date: Thu, 14 Jun 2012 09:39:04 +0100 Message-ID: <4FD9A328.9080000@linaro.org> References: <201206140804.39083.arnd@arndb.de> <4a198618063924b68182279ffd56c335d621f542.1339447570.git.rubini@gnudd.com> <20120614081758.GA19648@mail.gnudd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20120614081758.GA19648@mail.gnudd.com> Sender: linux-kernel-owner@vger.kernel.org To: Alessandro Rubini Cc: arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, giancarlo.asnaghi@st.com, linux@arm.linux.org.uk, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, w.sang@pengutronix.de, khali@linux-fr.org, linux-i2c@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, alan@linux.intel.com List-Id: linux-i2c@vger.kernel.org On 14/06/12 09:17, Alessandro Rubini wrote: >> You change only one half of ux500 here: the part where the device >> gets defined statically, but not not the definition in the >> device-tree. > > Yes, I'm aware. That's why I added Lee Jones as Cc:, on Linusw's > suggestion. Lee told me to go ahead and he'll fix the DT stuff. I did? I have already DT:ed this driver. There are 3 patches on the MLs curren= tly. > [PATCH 1/3] i2c: Add Device Tree support to the Nomadik I2C driver > [PATCH 2/3] ARM: ux500: Add i2c configurations to the Device Tree for= DB8500 based devices > [PATCH 3/3] Documentation: Device Tree binding information for i2c-no= madik driver I'm more than happy for you to base your patches on these and make the=20 necessary changes. Off hand, I think the only changes you'll need to=20 make is the probing from DT itself. So something like: > --- a/arch/arm/boot/dts/db8500.dtsi > +++ b/arch/arm/boot/dts/db8500.dtsi > @@ -449,7 +449,7 @@ > }; > > i2c@80004000 { > - compatible =3D "stericsson,db8500-i2c", "st,n= omadik-i2c"; > + compatible =3D "st,nomadik-i2c", "arm,primece= ll"; > reg =3D <0x80004000 0x1000>; > interrupts =3D <0 21 0x4>; > #address-cells =3D <1>; =2E.. for each of the controllers. --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog