From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver Date: Thu, 14 Jun 2012 19:59:49 +0100 Message-ID: <4FDA34A5.7070704@linaro.org> References: <1339428307-3850-1-git-send-email-lee.jones@linaro.org> <1339428307-3850-10-git-send-email-lee.jones@linaro.org> <4FD6F0E8.5040606@linaro.org> <4FD83AAD.2010701@linaro.org> <4FD88761.9050703@linaro.org> <20120614183636.GB30185@sirena.org.uk> <20120614184656.GD30185@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20120614184656.GD30185@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: linus.walleij@stericsson.com, arnd@arndb.de, Linus Walleij , linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-i2c@vger.kernel.org On 14/06/12 19:46, Mark Brown wrote: > On Thu, Jun 14, 2012 at 07:36:36PM +0100, Mark Brown wrote: > >> You're not understanding Linus' point. The compatible string isn't >> useful here because properties like the maximum clock rate of the bu= s >> depend on the board design, not the silicon. The controller may be >> perfectly happy to run at a given rate but other devices on the bus = or >> the electrical engineering of the PCB itself may restrict this furth= er. > > Sorry, I read the next revision and see this was actually resolved OK= =2E Yes, I just went ahead created the bindings anyway. I figured it would=20 be neater (if no more functional) to keep all the variations in DT.=20 Especially if we had devices which only varied by one or two settings,=20 which would still require a complete new struct using the previous meth= od. --=20 Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog