From: Shubhrajyoti <shubhrajyoti@ti.com>
To: balbi@ti.com
Cc: linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ben-linux@fluff.org,
tony@atomide.com, w.sang@pengutronix.de,
Kevin Hilman <khilman@ti.com>
Subject: Re: [PATCHv10 1/7] I2C: OMAP: I2C register restore only if context is lost
Date: Tue, 26 Jun 2012 11:38:07 +0530 [thread overview]
Message-ID: <4FE951C7.8070907@ti.com> (raw)
In-Reply-To: <20120625123000.GB30463@arwen.pp.htv.fi>
On Monday 25 June 2012 06:00 PM, Felipe Balbi wrote:
>> Cc: Kevin Hilman <khilman@ti.com>
>> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
> how will this ever work with DT ?
What you say makes sense however that is what currently
most of the omap drivers do.
Will check on this.
> I say we get rid of the OMAP-specific
> API and build this "context lost" status directly on dev_pm_info and
> have something like pm_runtime_lost_context() or something with pm QoS
> tell you if a device has lost its context.
>
> Also, your commit log doesn't really state any problems you might have
> reached before, or any improvements wrt latency coming out of suspend
> and so on.
>
> IMHO, drivers need a generic way to differentiate if they're resuming
> from OFF or RET, otherwise we will end up with a bunch of OMAP-specific
> hackery on all drivers
next prev parent reply other threads:[~2012-06-26 6:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 11:11 [PATCHv9 0/7] I2C cleanups Shubhrajyoti D
2012-06-25 11:11 ` [PATCHv10 1/7] I2C: OMAP: I2C register restore only if context is lost Shubhrajyoti D
2012-06-25 12:30 ` Felipe Balbi
2012-06-26 6:08 ` Shubhrajyoti [this message]
[not found] ` <4FE951C7.8070907-l0cyMroinI0@public.gmane.org>
2012-06-26 11:23 ` Shubhrajyoti
2012-06-25 11:11 ` [PATCHv10 4/7] I2C: OMAP: Do not initialise the completion everytime Shubhrajyoti D
[not found] ` <1340622702-21622-5-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 12:33 ` Felipe Balbi
2012-06-25 11:11 ` [PATCHv10 5/7] I2C: OMAP: Remove the definition of SYSS_RESETDONE_MASK Shubhrajyoti D
[not found] ` <1340622702-21622-6-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 12:34 ` Felipe Balbi
[not found] ` <1340622702-21622-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 11:11 ` [PATCHv10 2/7] I2C: OMAP: Optimise the remove code Shubhrajyoti D
2012-06-25 11:11 ` [PATCHv10 3/7] I2C: OMAP: Use SET_RUNTIME_PM_OPS Shubhrajyoti D
2012-06-25 11:11 ` [PATCHv10 6/7] I2C: OMAP: Correct I2C revision for OMAP3 Shubhrajyoti D
[not found] ` <1340622702-21622-7-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-06-25 12:35 ` Felipe Balbi
2012-06-25 11:11 ` [PATCHv10 7/7] I2C: OMAP: Recover from Bus Busy condition Shubhrajyoti D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE951C7.8070907@ti.com \
--to=shubhrajyoti@ti.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).