From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shubhrajyoti Subject: Re: [PATCHv10 1/7] I2C: OMAP: I2C register restore only if context is lost Date: Tue, 26 Jun 2012 16:53:21 +0530 Message-ID: <4FE99BA9.9030107@ti.com> References: <1340622702-21622-1-git-send-email-shubhrajyoti@ti.com> <1340622702-21622-2-git-send-email-shubhrajyoti@ti.com> <20120625123000.GB30463@arwen.pp.htv.fi> <4FE951C7.8070907@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FE951C7.8070907-l0cyMroinI0@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: balbi-l0cyMroinI0@public.gmane.org Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Kevin Hilman List-Id: linux-i2c@vger.kernel.org On Tuesday 26 June 2012 11:38 AM, Shubhrajyoti wrote: > On Monday 25 June 2012 06:00 PM, Felipe Balbi wrote: >>> Cc: Kevin Hilman >>>> Signed-off-by: Shubhrajyoti D >> how will this ever work with DT ? > What you say makes sense however that is what currently > most of the omap drivers do. > > Will check on this. >> I say we get rid of the OMAP-specific >> API and build this "context lost" status directly on dev_pm_info and >> have something like pm_runtime_lost_context() or something with pm QoS >> tell you if a device has lost its context. >> >> Also, your commit log doesn't really state any problems you might have >> reached before, Didnt see any issues while reviewing found that the restore was done always. >> or any improvements wrt latency coming out of suspend >> and so on. I am only restoring only 4-5 registers. >> >> IMHO, drivers need a generic way to differentiate if they're resuming >> from OFF or RET, otherwise we will end up with a bunch of OMAP-specific >> hackery on all drivers >