From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Ard Biesheuvel <ardb+git@google.com>,
linux-i2c@vger.kernel.org, stable@vger.kernel.org,
Andi Shyti <andi.shyti@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Wolfram Sang <wsa@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] i2c/synquacer: Deal with optional PCLK correctly
Date: Thu, 12 Sep 2024 19:37:22 +0200 [thread overview]
Message-ID: <4b15a9d3-23a4-43fe-a275-c9af11c6c8e1@wanadoo.fr> (raw)
In-Reply-To: <CAMj1kXEYpD4LdZ9jQebyViWW98ogX7=tKzQNLNZxdBUORgpnQg@mail.gmail.com>
Le 12/09/2024 à 19:12, Ard Biesheuvel a écrit :
> On Thu, 12 Sept 2024 at 19:11, Marion & Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
>>
>> (trying to merge t and cc fields from Ard's and Andy's messages)
>>
>>
>> Le 12/09/2024 à 12:46, Ard Biesheuvel a écrit :
>>> From: Ard Biesheuvel <ardb@kernel.org>
>>>
>>> ACPI boot does not provide clocks and regulators, but instead, provides
>>> the PCLK rate directly, and enables the clock in firmware. So deal
>>> gracefully with this.
>>>
>>> Fixes: 55750148e559 ("i2c: synquacer: Fix an error handling path in synquacer_i2c_probe()")
>>
>> Hi,
>>
>> If that matters, I'm not sure that the Fixes tag is correct.
>>
>> IIUC, either it is a new functionally that is added (now it works with
>> ACPI...), or if considered as a fix, then I think that it is linked to
>> commit 0d676a6c4390 ("i2c: add support for Socionext SynQuacer I2C
>> controller").
>>
>> I don't think that 55750148e559 introduced a regression. The issue seems
>> to be there since the beginning. Agreed?
>>
>
> No.
>
> The original code used IS_ERR_OR_NULL() to explicitly permit the case
> where no clock exists at all.
Got it, this is not related to the removed _OR_NULL, but to the change
of logic I've introduce.
if (!IS_ERR)
do_something_and_continue;
if_NOENT_was_returned_we_still_get_there();
which became:
if (IS_ERR)
return;
we_can_get_there_with_NOENT_anymore();
My bad!
CJ
>
> This has worked fine with ACPI boot for many years before this fix was applied.
>
>> If yes, then it may be needed to backport it in older kernels too.
>>
>
> No, it used to work. The fix is what broke ACPI boot.
>
next prev parent reply other threads:[~2024-09-12 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 10:46 [PATCH] i2c/synquacer: Deal with optional PCLK correctly Ard Biesheuvel
2024-09-12 17:10 ` Marion & Christophe JAILLET
2024-09-12 17:12 ` Ard Biesheuvel
2024-09-12 17:37 ` Christophe JAILLET [this message]
2024-09-20 9:03 ` Andi Shyti
2024-09-23 15:10 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b15a9d3-23a4-43fe-a275-c9af11c6c8e1@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=andi.shyti@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).