From: John Rigby <jcrigby@gmail.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-i2c@vger.kernel.org, linuxppc-dev@ozlabs.org,
Wolfgang Denk <wd@denx.de>, Detlev Zundel <dzu@denx.de>,
Piotr Ziecik <kosmo@semihalf.com>
Subject: Re: [PATCH 08/12] mpc5121: Added I2C support.
Date: Thu, 7 May 2009 20:12:54 -0600 [thread overview]
Message-ID: <4b73d43f0905071912k4bcc8821nabfa27aa5b1f587b@mail.gmail.com> (raw)
In-Reply-To: <fa686aa40905061941p6fd4b03dt1097cf4d16bdd665@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1341 bytes --]
Ok, the interrupt enabling should happen in the driver. Should it key off
compatible or should a new property be added like the existing 5200 clocking
property?
On Wed, May 6, 2009 at 8:41 PM, Grant Likely <grant.likely@secretlab.ca>wrote:
> On Wed, May 6, 2009 at 4:51 PM, Grant Likely <grant.likely@secretlab.ca>
> wrote:
> > On Wed, May 6, 2009 at 4:19 PM, Wolfgang Denk <wd@denx.de> wrote:
> >> Dear Grant Likely,
> >>
> >> In message <fa686aa40905061401k319313c5q89fd3e245c30808f@mail.gmail.com>
> you wrote:
> >>> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote:
> >>> > From: Piotr Ziecik <kosmo@semihalf.com>
> >>> >
> >>> > - Enabled I2C interrupts on MPC5121.
> >>> > - Updated Kconfig for i2c-mpc driver.
> >>>
> >>> I think this workaround belongs in the driver itself.
> >>
> >> Sorry, I don't get it. Which workaround? What exactly should I change?
> >
> > Sorry, I misread the patch. Never mind.
>
> Actually, on 3rd reading, I think my first impression was correct
> (even if I was wrong about it being a workaround). This code in
> mpc512x_init_i2c() is only relevant for i2c busses (it isn't shared
> with any other drivers). Therefore, it belongs with the i2c bus
> itself. It does not belong in platform code.
>
> Cheers,
> g.
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
>
[-- Attachment #1.2: Type: text/html, Size: 2143 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2009-05-08 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1241640919-4650-1-git-send-email-wd@denx.de>
[not found] ` <1241640919-4650-1-git-send-email-wd-ynQEQJNshbs@public.gmane.org>
2009-05-06 20:15 ` [PATCH 08/12] mpc5121: Added I2C support Wolfgang Denk
[not found] ` <1241640919-4650-9-git-send-email-wd-ynQEQJNshbs@public.gmane.org>
2009-05-06 21:01 ` Grant Likely
[not found] ` <fa686aa40905061401k319313c5q89fd3e245c30808f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-06 22:19 ` Wolfgang Denk
2009-05-06 22:51 ` Grant Likely
[not found] ` <fa686aa40905061551l8cf5940sf4d4cbf34331cf9a-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-07 2:41 ` Grant Likely
[not found] ` <fa686aa40905061941p6fd4b03dt1097cf4d16bdd665-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-05-07 6:36 ` Wolfgang Grandegger
2009-05-18 13:57 ` Piotr Zięcik
2009-05-18 14:11 ` Grant Likely
[not found] ` <200905181557.11766.kosmo-nYOzD4b6Jr9Wk0Htik3J/w@public.gmane.org>
2009-05-18 14:29 ` Wolfgang Grandegger
[not found] ` <4A1170B0.5080203-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2009-05-19 7:47 ` Piotr Zięcik
2009-05-19 8:10 ` Wolfgang Grandegger
2009-05-08 2:12 ` John Rigby [this message]
2009-05-08 3:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b73d43f0905071912k4bcc8821nabfa27aa5b1f587b@mail.gmail.com \
--to=jcrigby@gmail.com \
--cc=dzu@denx.de \
--cc=grant.likely@secretlab.ca \
--cc=kosmo@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).