From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-spi@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Mark Brown <broonie@kernel.org>,
linux-i2c@vger.kernel.org, kernel@pengutronix.de,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH 13/13] tpm: st33zp24: Make st33zp24_remove() return void
Date: Tue, 12 Oct 2021 20:46:42 +0300 [thread overview]
Message-ID: <4e0b7850e901864632c22551ecd7f137530c9770.camel@kernel.org> (raw)
In-Reply-To: <20211012174052.iekzt22ojilca5lc@pengutronix.de>
On Tue, 2021-10-12 at 19:40 +0200, Uwe Kleine-König wrote:
> On Tue, Oct 12, 2021 at 07:47:22PM +0300, Jarkko Sakkinen wrote:
> > On Mon, 2021-10-11 at 15:27 +0200, Uwe Kleine-König wrote:
> > > Up to now st33zp24_remove() returns zero unconditionally. Make it return
> > > void instead which makes it easier to see in the callers that there is
> > > no error to handle.
> >
> > So, void is not a return value.
>
> Hmm, would you be more happy with "Make it return no value"? I think
> this is less understandable than "Make it return void". Do you have a
> constructive suggestion how to formulate.
I think it is semantically more correct to say that it does not return
any value, given that it does not do that :-) You can just state e.g.
"Make st33zp24_remove() a void function.", it is semantically sound and
not really that confusing.
/Jarkko
next prev parent reply other threads:[~2021-10-12 17:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 13:27 [PATCH 00/13] Make some spi device drivers return zero in .remove() Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 02/13] hwmon: adt7x10: Make adt7x10_remove() return void Uwe Kleine-König
2021-10-11 14:19 ` Guenter Roeck
2021-10-11 13:27 ` [PATCH 04/13] input: adxl34xx: Make adxl34x_remove() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 05/13] input: touchscreen: tsc200x: Make tsc200x_remove() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 07/13] mfd: mc13xxx: Make mc13xxx_common_exit() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 08/13] mfd: stmpe: Make stmpe_remove() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 09/13] mfd: tps65912: Make tps65912_device_exit() " Uwe Kleine-König
2021-10-11 13:27 ` [PATCH 13/13] tpm: st33zp24: Make st33zp24_remove() " Uwe Kleine-König
2021-10-12 16:47 ` Jarkko Sakkinen
2021-10-12 17:40 ` Uwe Kleine-König
2021-10-12 17:46 ` Jarkko Sakkinen [this message]
2021-10-11 20:42 ` [PATCH 00/13] Make some spi device drivers return zero in .remove() Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0b7850e901864632c22551ecd7f137530c9770.camel@kernel.org \
--to=jarkko@kernel.org \
--cc=broonie@kernel.org \
--cc=jgg@ziepe.ca \
--cc=kernel@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).