From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH 04/12] i2c: pxa: Add support for pxa910/988 & new configuration features Date: Mon, 01 Jun 2015 09:13:03 +0900 Message-ID: <4edfb7fe9edf4800e73c86a258fe4fd1@the-dreams.de> References: <1432818224-17070-1-git-send-email-vaibhav.hiremath@linaro.org> <1432818224-17070-5-git-send-email-vaibhav.hiremath@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432818224-17070-5-git-send-email-vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vaibhav Hiremath Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "Jett.Zhou" , Yi Zhang List-Id: linux-i2c@vger.kernel.org On 2015-05-28 22:03, Vaibhav Hiremath wrote: > From: "Jett.Zhou" > > TWSI_ILCR & TWSI_IWCR registers are used to adjust clock rate > of standard & fast mode in pxa910/988; so this patch adds these two > new > entries to "struct pxa_reg_layout" and "struct pxa_i2c" and also adds > two > new DT properties to take configuration value for the same. Mapping registers 1:1 to DT is nearly always wrong. We have some generic bindings for SCL/SDA tweaking. Check Documentation/devicetree/bindings/i2c/i2c-designware.txt for them and if they match your needs. (Yes, they should be in a more generic place).