From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>, Andi Shyti <andi.shyti@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: qup: Propagate clock enable failures
Date: Wed, 24 Jun 2026 09:47:18 +0200 [thread overview]
Message-ID: <4fe3e01e-93f7-4832-b93e-d006c644b3ce@oss.qualcomm.com> (raw)
In-Reply-To: <20260624055237.29977-1-pengpeng@iscas.ac.cn>
On 6/24/26 7:52 AM, Pengpeng Hou wrote:
> The QUP I2C driver treats the core and iface clocks as required
> resources, but qup_i2c_enable_clocks() ignores clk_prepare_enable()
> failures. Probe can then continue to register the I2C adapter, and
> runtime/system resume can return success, even when a required clock
> transition failed.
>
> Make the helper return an error, unwind a partially enabled clock, and
> propagate failures from probe and resume paths.
>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-06-24 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 5:52 [PATCH] i2c: qup: Propagate clock enable failures Pengpeng Hou
2026-06-24 7:47 ` Konrad Dybcio [this message]
2026-07-28 21:45 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe3e01e-93f7-4832-b93e-d006c644b3ce@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pengpeng@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox