From: Randy Dunlap <rdunlap@xenotime.net>
To: Jean Delvare <khali@linux-fr.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Mark Studebaker <mdsxyz123@yahoo.com>,
linux-i2c@vger.kernel.org
Subject: Re: linux-next: Tree for Aug 3 (drivers/i2c/busses/i2c-i801.c)
Date: Fri, 03 Aug 2012 14:36:57 -0700 [thread overview]
Message-ID: <501C4479.4030306@xenotime.net> (raw)
In-Reply-To: <20120803215717.31376eb7@endymion.delvare>
On 08/03/2012 12:57 PM, Jean Delvare wrote:
> Hi Randy,
>
> On Fri, 03 Aug 2012 10:24:34 -0700, Randy Dunlap wrote:
>> on x86_64:
>>
>> when CONFIG_GPIOLIB is not enabled:
>>
>> drivers/i2c/busses/i2c-i801.c: In function 'match_gpio_chip_by_label':
>> drivers/i2c/busses/i2c-i801.c:1011:21: error: dereferencing pointer to incomplete type
>> drivers/i2c/busses/i2c-i801.c: In function 'i801_add_mux':
>> drivers/i2c/busses/i2c-i801.c:1028:2: error: implicit declaration of function 'gpiochip_find'
>> drivers/i2c/busses/i2c-i801.c:1028:7: warning: assignment makes pointer from integer without a cast
>> drivers/i2c/busses/i2c-i801.c:1047:27: error: dereferencing pointer to incomplete type
>> drivers/i2c/busses/i2c-i801.c: In function 'match_gpio_chip_by_label':
>> drivers/i2c/busses/i2c-i801.c:1012:1: warning: control reaches end of non-void function
>
> Good catch, thanks for reporting. I'll fold the following in the
> offending patch, that should fix it:
Ack, it does.
Thanks.
> --- linux-3.6-rc0.orig/drivers/i2c/busses/Kconfig 2012-08-03 21:51:51.000000000 +0200
> +++ linux-3.6-rc0/drivers/i2c/busses/Kconfig 2012-08-03 21:52:18.090537018 +0200
> @@ -80,6 +80,7 @@ config I2C_I801
> tristate "Intel 82801 (ICH/PCH)"
> depends on PCI
> select CHECK_SIGNATURE if X86 && DMI
> + select GPIOLIB if I2C_MUX
> help
> If you say yes to this option, support will be included for the Intel
> 801 family of mainboard I2C interfaces. Specifically, the following
>
>
--
~Randy
prev parent reply other threads:[~2012-08-03 21:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120803135110.0ba0e51758021b6a4ed9d1e9@canb.auug.org.au>
2012-08-03 17:24 ` linux-next: Tree for Aug 3 (drivers/i2c/busses/i2c-i801.c) Randy Dunlap
2012-08-03 19:57 ` Jean Delvare
2012-08-03 21:36 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501C4479.4030306@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mdsxyz123@yahoo.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).