From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [PATCH v7] ARM: davinci: i2c: add OF support Date: Tue, 07 Aug 2012 16:35:16 +0200 Message-ID: <502127A4.2040505@denx.de> References: <1343632872-25896-1-git-send-email-hs@denx.de> Reply-To: hs-ynQEQJNshbs@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7BIT Return-path: In-reply-to: <1343632872-25896-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Heiko Schocher Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org, Sekhar Nori , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Wolfram Sang , Grant Likely , Wolfgang Denk , Sylwester Nawrocki List-Id: linux-i2c@vger.kernel.org Hello, On 30.07.2012 09:21, Heiko Schocher wrote: > add of support for the davinci i2c driver. > > Signed-off-by: Heiko Schocher > Signed-off-by: Sekhar Nori > Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org > Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Ben Dooks > Cc: Wolfram Sang > Cc: Grant Likely > Cc: Sekhar Nori > Cc: Wolfgang Denk > Cc: Sylwester Nawrocki > > --- > - changes for v2: > - add comments from Sylwester Nawrocki: > - use "cell-index" instead "id" > - OF_DEV_AUXDATA in the machine code, instead pre-define platform > device name > - add comment from Grant Likely: > - removed "id" resp. "cell-index" completely > - fixed documentation > - use of_match_ptr() > - use devm_kzalloc() for allocating plattform data mem > - fixed a whitespace issue > - no changes for v3 > - changes for v4 > remove "pinmux-handle" property as discussed here: > http://www.spinics.net/lists/arm-kernel/msg175701.html > with Nori Sekhar > > - changes for v5 > add comments from Grant Likely: > - do not change value of dev->dev->platform_data, instead > hold a copy in davinci_i2c_dev. > > - changes for v6: > add comments from Sekhar Nori: > - removed unneccessary include > - merge patch from Sekhar Nori: > setup the newly introduced dev->pdata member correctly once in > probe -> i2c_get_plattformdata(() not needed, remove a lot of > checks for pdata in code > - add Signed-off-by: Sekhar Nori > - patch no longer in patchserie, as it has no dependencies. > > - changes for v7: > add comments from Wolfram Sang: > - move Documentation/devicetree/bindings/arm/davinci/i2c.txt > to Documentation/devicetree/bindings/i2c/davinci.txt > - remove bus-delay property > > Documentation/devicetree/bindings/i2c/davinci.txt | 28 ++++++++++++ > drivers/i2c/busses/i2c-davinci.c | 48 ++++++++++++++++----- > 2 files changed, 65 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/i2c/davinci.txt ping ... any comments? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany