From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Crispin Subject: Re: [PATCH] I2C: MIPS: lantiq: add FALC-ON i2c bus master Date: Thu, 16 Aug 2012 11:02:46 +0200 Message-ID: <502CB736.6010107@openwrt.org> References: <1345102448-4612-1-git-send-email-blogic@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shubhrajyoti Datta Cc: Wolfram Sang , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Thomas Langer List-Id: linux-i2c@vger.kernel.org Hi Shubhrajyoti, Thanks for the comments, I just noticed that clk_put() is also missing and that the clock gate should be deactivated upon a rmmod ... i will fix all of these and resend the patch. John