From: ludovic.desroches <ludovic.desroches@atmel.com>
To: "Voss, Nikolaus" <N.Voss@weinmann.de>
Cc: "'rmallon@gmail.com'" <rmallon@gmail.com>,
"'nicolas.ferre@atmel.com'" <nicolas.ferre@atmel.com>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'balbi@ti.com'" <balbi@ti.com>,
"'h.feurstein@gmail.com'" <h.feurstein@gmail.com>,
"'ludovic.desroches'" <ludovic.desroches@atmel.com>,
"'linux-i2c@vger.kernel.org'" <linux-i2c@vger.kernel.org>,
"'ben-linux@fluff.org'" <ben-linux@fluff.org>,
"'adrian.yanes@aalto.fi'" <adrian.yanes@aalto.fi>,
"'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>,
"'carsten.behling@garz-fricke.com'"
<carsten.behling@garz-fricke.com>
Subject: Re: [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios
Date: Mon, 27 Aug 2012 15:27:48 +0200 [thread overview]
Message-ID: <503B75D4.2030803@atmel.com> (raw)
In-Reply-To: <EF2E73589CA71846A15D0B2CDF79505D090EC3D6E4@wm021.weinmann.com>
Le 08/27/2012 03:22 PM, Voss, Nikolaus a écrit :
> Hi Ludovic,
>
> ludovic.desroches wrote on Monday, August 27, 2012 12:25 PM:
>> Le 11/08/2011 12:11 PM, Nikolaus Voss a écrit :
>>> The G45 datasheets explicitly states that setting the open drain property
>>> on peripheral function gpios is not allowed. (How about other A91 chips?)
>>
>> Did you remove open drain because you had some issues or because you
>> had seen it into datasheet?
>>
>> I tried with and without open drain. The behavior was the same. Looking
>> to the G45 datasheet, I didn't see that the open drain property is not
>> allowed on peripheral function gpios:
>>
>> 'The Multi Drive can be selected whether the I/O line
>> is controlled by the PIO controller or assigned to a peripheral function.'
>>
>> The datasheet should have been updated or there is another place where
>> it is mentioned that open drain property is not allowed in this case.
>
> well, it didn't work on my G45. I found the following note in the
> TWI chapter 31.6.1 of the G45 datasheet:
> "The user must not program TWD and TWCK as open-drain.
> It is already done by the hardware."
Ok so it seems there is a contradiction. I'll try to inquire about this
point.
Regards
Ludovic
>
> After removing the open-drain setting, it worked.
>
> Regards,
> Nikolaus
>
>
>
>
next prev parent reply other threads:[~2012-08-27 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 6:59 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
[not found] ` <cover.1345618760.git.n.voss-+umVssTZoCsb1SvskN2V4Q@public.gmane.org>
2011-11-08 10:49 ` [PATCH v11 1/4] drivers/i2c/busses/i2c-at91.c: remove old polling driver Nikolaus Voss
2011-11-08 10:49 ` [PATCH v11 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Nikolaus Voss
2012-08-27 10:16 ` ludovic.desroches
2012-08-27 10:40 ` Yanes Martinez Adrian
2012-08-27 12:04 ` ludovic.desroches
2012-08-27 12:45 ` Yanes Martinez Adrian
[not found] ` <BC0F374A1C27184AB96177CDFEC2F54225ECD36E-rZDk5e4OVTsRAxgRyUl6SBEi2Xg3O0b1@public.gmane.org>
2012-08-27 13:32 ` Voss, Nikolaus
2012-08-27 14:00 ` ludovic.desroches
2012-08-27 14:29 ` Voss, Nikolaus
2012-09-11 8:26 ` Nicolas Ferre
[not found] ` <504EF5BF.2090404-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-11 22:13 ` Wolfram Sang
2012-08-30 7:35 ` ludovic.desroches
2012-08-28 15:10 ` ludovic.desroches
2012-08-28 15:32 ` Voss, Nikolaus
2011-11-08 11:09 ` [PATCH v11 2/4] Replace clk_lookup.con_id with clk_lookup.dev_id entries for twi clk Nikolaus Voss
2011-11-08 11:11 ` [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss
2012-08-27 10:24 ` ludovic.desroches
2012-08-27 13:22 ` Voss, Nikolaus
2012-08-27 13:27 ` ludovic.desroches [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-29 7:28 [PATCH v11 0/4] AT91: replace old i2c-at91.c TWI driver Nikolaus Voss
2011-11-08 11:11 ` [PATCH v11 4/4] G45 TWI: remove open drain setting for twi function gpios Nikolaus Voss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503B75D4.2030803@atmel.com \
--to=ludovic.desroches@atmel.com \
--cc=N.Voss@weinmann.de \
--cc=adrian.yanes@aalto.fi \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=carsten.behling@garz-fricke.com \
--cc=h.feurstein@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).