From: Shubhrajyoti <shubhrajyoti-l0cyMroinI0@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCHv7 18/23] i2c: omap: remove redundant status read
Date: Wed, 12 Sep 2012 12:21:49 +0530 [thread overview]
Message-ID: <50503105.8050100@ti.com> (raw)
In-Reply-To: <20120911215441.GC27031-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
On Wednesday 12 September 2012 03:24 AM, Wolfram Sang wrote:
> On Tue, Sep 11, 2012 at 03:12:13PM +0530, Shubhrajyoti D wrote:
>> Remove the redundant read of the status register.
> Commit message is just repeating the subject.
> Why was the read there and why can it be removed now?
>
It is read and it is not read anywhere below.
>> Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org>
>> ---
>> drivers/i2c/busses/i2c-omap.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
>> index 5d4bad4..498a462 100644
>> --- a/drivers/i2c/busses/i2c-omap.c
>> +++ b/drivers/i2c/busses/i2c-omap.c
>> @@ -946,7 +946,6 @@ omap_i2c_isr(int this_irq, void *dev_id)
>> num_bytes = dev->buf_len;
>>
>> ret = omap_i2c_transmit_data(dev, num_bytes, true);
>> - stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
>> if (ret < 0)
>> goto out;
>>
>> @@ -962,7 +961,6 @@ omap_i2c_isr(int this_irq, void *dev_id)
>> num_bytes = dev->threshold;
>>
>> ret = omap_i2c_transmit_data(dev, num_bytes, false);
>> - stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG);
>> if (ret < 0)
>> goto out;
>>
>> --
>> 1.7.5.4
>>
next prev parent reply other threads:[~2012-09-12 6:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 9:41 [PATCHv7 00/23]I2C big cleanup Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 01/23] i2c: omap: switch to devm_* API Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 02/23] i2c: omap: simplify num_bytes handling Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 04/23] i2c: omap: add blank lines Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 07/23] i2c: omap: improve i462 errata handling Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 08/23] i2c: omap: re-factor receive/transmit data loop Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 10/23] i2c: omap: ack IRQ in parts Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 11/23] i2c: omap: switch to platform_get_irq() Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 12/23] i2c: omap: bus: add a receiver flag Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 13/23] i2c: omap: simplify errata check Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 14/23] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 16/23] i2c: omap: resize fifos before each message Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 17/23] i2c: omap: get rid of the "complete" label Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 19/23] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D
[not found] ` <1347356538-23835-20-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-09-11 21:53 ` Wolfram Sang
[not found] ` <20120911215341.GB27031-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 6:42 ` Shubhrajyoti
2012-09-11 9:42 ` [PATCHv7 21/23] i2c: omap: remove unnecessary pm_runtime_suspended check Shubhrajyoti D
[not found] ` <1347356538-23835-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-09-11 9:41 ` [PATCHv7 03/23] i2c: omap: decrease indentation level on data handling Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 05/23] i2c: omap: simplify omap_i2c_ack_stat() Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 06/23] i2c: omap: split out [XR]DR and [XR]RDY Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 09/23] i2c: omap: switch over to do {} while loop Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 15/23] i2c: omap: simplify IRQ exit path Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 18/23] i2c: omap: remove redundant status read Shubhrajyoti D
[not found] ` <1347356538-23835-19-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-09-11 21:54 ` Wolfram Sang
[not found] ` <20120911215441.GC27031-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 6:51 ` Shubhrajyoti [this message]
2012-09-11 9:42 ` [PATCHv7 20/23] i2c: omap: switch to threaded IRQ support Shubhrajyoti D
2012-09-11 21:51 ` Wolfram Sang
[not found] ` <20120911215112.GA27031-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 6:25 ` Shubhrajyoti
2012-09-12 11:51 ` Wolfram Sang
2012-09-11 9:42 ` [PATCHv7 22/23] i2c: omap: switch over to autosuspend API Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 23/23] i2c: omap: sanitize exit path Shubhrajyoti D
2012-09-11 22:00 ` [PATCHv7 00/23]I2C big cleanup Wolfram Sang
2012-09-12 10:11 ` Shubhrajyoti
[not found] ` <50505FDC.4090500-l0cyMroinI0@public.gmane.org>
2012-09-12 10:18 ` Wolfram Sang
[not found] ` <20120912101850.GB2624-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 13:44 ` Wolfram Sang
[not found] ` <20120912134427.GC16547-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 14:40 ` Shubhrajyoti Datta
2012-09-11 10:18 ` Shubhrajyoti
2012-09-11 12:05 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50503105.8050100@ti.com \
--to=shubhrajyoti-l0cymroini0@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).