From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 0244/1285] Replace numeric parameter like 0444 with macro Date: Wed, 10 Aug 2016 15:45:30 +0200 Message-ID: <5052478.g1CZhtD17T@wuerfel> References: <20160802105246.30008-1-baolex.ni@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: linux-arm-kernel@lists.infradead.org Cc: Krzysztof =?utf-8?B?S296xYJvd3NraQ==?= , Wolfram Sang , Dave Airlie , Linus Walleij , "linux-kernel@vger.kernel.org" , Doug Anderson , Baole Ni , Andrew Duggan , Kukjin Kim , Borislav Petkov , "linux-i2c@vger.kernel.org" , dougthompson@xmission.com, chuansheng.liu@intel.com, Guenter Roeck List-Id: linux-i2c@vger.kernel.org On Wednesday, August 10, 2016 3:02:05 PM CEST Linus Walleij wrote: > On Tue, Aug 2, 2016 at 12:52 PM, Baole Ni wrote: > > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access permission. > > As we know, these numeric value for access permission have had the corresponding macro, > > and that using macro can improve the robustness and readability of the code, > > thus, I suggest replacing the numeric parameter with the macro. > > > > Signed-off-by: Chuansheng Liu > > Signed-off-by: Baole Ni > > Acked-by: Linus Walleij > > I assume Wolfram will merge this. I assume not, see http://lwn.net/Articles/696227/ Arnd