From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH v2 3/7] i2c: omap: also complete() when stat becomes zero Date: Thu, 25 Oct 2012 18:13:16 +0530 Message-ID: <508933E4.7070608@ti.com> References: <1350899218-13624-1-git-send-email-balbi@ti.com> <1351167915-15079-1-git-send-email-balbi@ti.com> <1351167915-15079-4-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1351167915-15079-4-git-send-email-balbi-l0cyMroinI0@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux OMAP Mailing List , Linux ARM Kernel Mailing List , Tony Lindgren , Shubhrajyoti Datta , Benoit Cousson , w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Thursday 25 October 2012 05:55 PM, Felipe Balbi wrote: > In case we loop on IRQ handler until stat is > finally zero, we would end up in a situation > where all I2C transfers would misteriously > timeout because we were not calling complete() > in that situation. > > Fix the issue by moving omap_i2c_complete_cmd() > call inside the 'out' label. > > Signed-off-by: Felipe Balbi > --- Looks fine. Have you hit this issue in any corner case ? Regards santosh