From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40E8FA373D for ; Tue, 1 Nov 2022 12:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230019AbiKAMyt (ORCPT ); Tue, 1 Nov 2022 08:54:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230387AbiKAMyi (ORCPT ); Tue, 1 Nov 2022 08:54:38 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E966CE35; Tue, 1 Nov 2022 05:54:36 -0700 (PDT) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4N1qjN5lRtz15MFl; Tue, 1 Nov 2022 20:54:32 +0800 (CST) Received: from [10.67.102.169] (10.67.102.169) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 20:54:34 +0800 CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH next v10 2/2] dt-bindings: i2c: add entry for hisilicon,ascend910-i2c To: Weilong Chen References: <20221101080728.143639-1-chenweilong@huawei.com> <20221101080728.143639-2-chenweilong@huawei.com> From: Yicong Yang Message-ID: <50934335-b088-ae36-490c-e48a74fb755e@huawei.com> Date: Tue, 1 Nov 2022 20:54:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20221101080728.143639-2-chenweilong@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.169] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 2022/11/1 16:07, Weilong Chen wrote: > Add the new compatible for HiSilicon i2c. > Reviewed-by: Yicong Yang > Signed-off-by: Weilong Chen > Reviewed-by: Rob Herring > --- > Change since v9: > - No change > Link: https://lore.kernel.org/lkml/20221029115937.179788-2-chenweilong@huawei.com/ > > Change since v8: > - Use vendor,soc-ipblock format. > - Drop quotes. > - Drop "Device Tree bindings". > - Description goes to top level description. > - Use defines for constants. > Link: https://lore.kernel.org/lkml/20221024015151.342651-2-chenweilong@huawei.com/ > > .../bindings/i2c/hisilicon,ascend910-i2c.yaml | 73 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml > new file mode 100644 > index 000000000000..7d7a8de7bcd8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/hisilicon,ascend910-i2c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: HiSilicon common I2C controller > + > +maintainers: > + - Yicong Yang > + > +description: > + The HiSilicon common I2C controller can be used for many different > + types of SoC such as Huawei Ascend AI series chips. > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + const: hisilicon,ascend910-i2c > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-frequency: > + default: 400000 > + > + i2c-sda-falling-time-ns: > + default: 343 > + > + i2c-scl-falling-time-ns: > + default: 203 > + > + i2c-sda-hold-time-ns: > + default: 830 > + > + i2c-scl-rising-time-ns: > + default: 365 > + > + i2c-digital-filter-width-ns: > + default: 0 > + > +required: > + - compatible > + - reg > + - interrupts > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + > + i2c@38b0000 { > + compatible = "hisilicon,ascend910-i2c"; > + reg = <0x38b0000 0x10000>; > + interrupts = ; > + i2c-sda-falling-time-ns = <56>; > + i2c-scl-falling-time-ns = <56>; > + i2c-sda-hold-time-ns = <56>; > + i2c-scl-rising-time-ns = <56>; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <0x0>; > + clocks = <&alg_clk>; > + clock-frequency = <400000>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index d1214d83c2df..d42e34d1e8e2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -9228,6 +9228,7 @@ M: Yicong Yang > L: linux-i2c@vger.kernel.org > S: Maintained > W: https://www.hisilicon.com > +F: Documentation/devicetree/bindings/i2c/hisilicon,ascend910-i2c.yaml > F: drivers/i2c/busses/i2c-hisi.c > > HISILICON LPC BUS DRIVER >