linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
	w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH 2/3] i2c: at91: change struct members indentation
Date: Thu, 15 Nov 2012 18:19:00 +0100	[thread overview]
Message-ID: <50A52404.9000503@atmel.com> (raw)
In-Reply-To: <1352911493-6979-3-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

On 11/14/2012 05:44 PM, ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org :
> From: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> 
> Replace tabs for struct members indentation by space to minimise line changes
> when adding new members which would require extra tabs to keep alignment.

Lol, you followed Wolfram's advice... You know my preferences ;-)

> Signed-off-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

Ok, then:

Acked-by: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>

> ---
>  drivers/i2c/busses/i2c-at91.c | 30 +++++++++++++++---------------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index dc8cb22..2c437df 100644
> --- a/drivers/i2c/busses/i2c-at91.c
> +++ b/drivers/i2c/busses/i2c-at91.c
> @@ -66,24 +66,24 @@
>  #define	AT91_TWI_THR		0x0034	/* Transmit Holding Register */
>  
>  struct at91_twi_pdata {
> -	unsigned	clk_max_div;
> -	unsigned	clk_offset;
> -	bool		has_unre_flag;
> +	unsigned clk_max_div;
> +	unsigned clk_offset;
> +	bool has_unre_flag;
>  };
>  
>  struct at91_twi_dev {
> -	struct device		*dev;
> -	void __iomem		*base;
> -	struct completion	cmd_complete;
> -	struct clk		*clk;
> -	u8			*buf;
> -	size_t			buf_len;
> -	struct i2c_msg		*msg;
> -	int			irq;
> -	unsigned		transfer_status;
> -	struct i2c_adapter	adapter;
> -	unsigned		twi_cwgr_reg;
> -	struct at91_twi_pdata	*pdata;
> +	struct device *dev;
> +	void __iomem *base;
> +	struct completion cmd_complete;
> +	struct clk *clk;
> +	u8 *buf;
> +	size_t buf_len;
> +	struct i2c_msg *msg;
> +	int irq;
> +	unsigned transfer_status;
> +	struct i2c_adapter adapter;
> +	unsigned twi_cwgr_reg;
> +	struct at91_twi_pdata *pdata;
>  };
>  
>  static unsigned at91_twi_read(struct at91_twi_dev *dev, unsigned reg)
> 


-- 
Nicolas Ferre

  parent reply	other threads:[~2012-11-15 17:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14 16:44 [PATCH v3 0/3] i2c: at91: add dma support ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found] ` <1352911493-6979-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-14 16:44   ` [PATCH 1/3] i2c: at91: fix compilation warning ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found]     ` <1352911493-6979-2-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-15 17:16       ` Nicolas Ferre
2012-11-14 16:44   ` [PATCH 2/3] i2c: at91: change struct members indentation ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found]     ` <1352911493-6979-3-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-15 17:19       ` Nicolas Ferre [this message]
2012-11-14 16:44   ` [PATCH 3/3] i2c: at91: add dma support ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found]     ` <1352911493-6979-4-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-15 17:21       ` Nicolas Ferre
2012-11-16 17:05   ` [PATCH v3 0/3] " Wolfram Sang
2012-11-21  9:45     ` ludovic.desroches
     [not found]       ` <50ACA2D4.9040904-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-22 21:40         ` Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2012-11-23  9:09 [RESEND PATCH " ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
     [not found] ` <1353661744-5703-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-11-23  9:09   ` [PATCH 2/3] i2c: at91: change struct members indentation ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A52404.9000503@atmel.com \
    --to=nicolas.ferre-aife0yeh4naavxtiumwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
    --cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).