From: Heiner Kallweit <hkallweit1@gmail.com>
To: Jean Delvare <jdelvare@suse.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: [PATCH v2 03/10] i2c: i801: make FEATURE_BLOCK_PROC dependent on FEATURE_BLOCK_BUFFER
Date: Mon, 19 Dec 2022 19:15:25 +0100 [thread overview]
Message-ID: <50f333a1-2f62-4a2d-5527-7a17eb49ec68@gmail.com> (raw)
In-Reply-To: <8db86d89-d083-2a65-76a1-6db34f433604@gmail.com>
According to the datasheet the block process call requires block
buffer mode. The user may disable block buffer mode by module
parameter disable_features, in such a case we have to clear
FEATURE_BLOCK_PROC.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- add a commit message part as comment to the code
---
drivers/i2c/busses/i2c-i801.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 45c2ebe40..2e9c5856a 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1658,6 +1658,10 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
}
priv->features &= ~disable_features;
+ /* The block process call uses block buffer mode */
+ if (!(priv->features & FEATURE_BLOCK_BUFFER))
+ priv->features &= ~FEATURE_BLOCK_PROC;
+
err = pcim_enable_device(dev);
if (err) {
dev_err(&dev->dev, "Failed to enable SMBus PCI device (%d)\n",
--
2.39.0
next prev parent reply other threads:[~2022-12-19 18:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 18:12 [PATCH v2 00/10] i2c: i801: Series with minor improvements Heiner Kallweit
2022-12-19 18:13 ` [PATCH v2 01/10] i2c: i801: improve interrupt handler Heiner Kallweit
2023-02-10 8:28 ` Jean Delvare
2023-02-12 21:11 ` Wolfram Sang
2022-12-19 18:14 ` [PATCH v2 02/10] i2c: i801: make FEATURE_HOST_NOTIFY dependent on FEATURE_IRQ Heiner Kallweit
2023-02-10 8:29 ` Jean Delvare
2023-02-12 21:11 ` Wolfram Sang
2022-12-19 18:15 ` Heiner Kallweit [this message]
2023-02-10 8:30 ` [PATCH v2 03/10] i2c: i801: make FEATURE_BLOCK_PROC dependent on FEATURE_BLOCK_BUFFER Jean Delvare
2023-02-12 21:11 ` Wolfram Sang
2022-12-19 18:16 ` [PATCH v2 04/10] i2c: i801: add helper i801_set_hstadd() Heiner Kallweit
2023-02-10 8:31 ` Jean Delvare
2023-02-12 21:12 ` Wolfram Sang
2022-12-19 18:17 ` [PATCH v2 05/10] i2c: i801: add i801_simple_transaction(), complementing i801_block_transaction() Heiner Kallweit
2023-02-13 17:04 ` Jean Delvare
2022-12-19 18:20 ` [PATCH v2 06/10] i2c: i801: handle SMBAUXCTL_E32B in i801_block_transaction_by_block only Heiner Kallweit
2023-02-13 16:47 ` Jean Delvare
2022-12-19 18:20 ` [PATCH v2 07/10] i2c: i801: centralize configuring non-block commands in i801_simple_transaction Heiner Kallweit
2023-02-15 15:13 ` Jean Delvare
2022-12-19 18:21 ` [PATCH v2 08/10] i2c: i801: centralize configuring block commands in i801_block_transaction Heiner Kallweit
2023-02-15 15:16 ` Jean Delvare
2022-12-19 18:22 ` [PATCH v2 09/10] i2c: i801: call i801_check_pre() from i801_access() Heiner Kallweit
2022-12-19 18:22 ` [PATCH v2 10/10] i2c: i801: call i801_check_post() " Heiner Kallweit
2023-02-15 17:09 ` Jean Delvare
2023-02-15 17:16 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50f333a1-2f62-4a2d-5527-7a17eb49ec68@gmail.com \
--to=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).