* [PATCH -next] i2c: fix i2c-ismt.c printk format warning
[not found] <20130215184255.5ba8a085004f4aadb9faf82c@canb.auug.org.au>
@ 2013-02-15 18:51 ` Randy Dunlap
2013-02-15 19:48 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2013-02-15 18:51 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Bill E. Brown, Jean Delvare,
Seth Heasley, Neil Horman, Wolfram Sang, linux-i2c
From: Randy Dunlap <rdunlap@infradead.org>
Fix printk format warning. dma_addr_t can be 32-bit or 64-bit,
so cast it to long long for printing. This also matches the
printk format specifier that is already used.
drivers/i2c/busses/i2c-ismt.c:532:3: warning: format '%llX' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Bill E. Brown <bill.e.brown@intel.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Seth Heasley <seth.heasley@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-i2c@vger.kernel.org
---
drivers/i2c/busses/i2c-ismt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20130215.orig/drivers/i2c/busses/i2c-ismt.c
+++ linux-next-20130215/drivers/i2c/busses/i2c-ismt.c
@@ -530,7 +530,7 @@ static int ismt_access(struct i2c_adapte
}
dev_dbg(dev, " dma_addr = 0x%016llX\n",
- dma_addr);
+ (unsigned long long)dma_addr);
desc->dptr_low = lower_32_bits(dma_addr);
desc->dptr_high = upper_32_bits(dma_addr);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] i2c: fix i2c-ismt.c printk format warning
2013-02-15 18:51 ` [PATCH -next] i2c: fix i2c-ismt.c printk format warning Randy Dunlap
@ 2013-02-15 19:48 ` Wolfram Sang
0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2013-02-15 19:48 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, linux-next, linux-kernel, Bill E. Brown,
Jean Delvare, Seth Heasley, Neil Horman, linux-i2c
On Fri, Feb 15, 2013 at 10:51:40AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix printk format warning. dma_addr_t can be 32-bit or 64-bit,
> so cast it to long long for printing. This also matches the
> printk format specifier that is already used.
>
> drivers/i2c/busses/i2c-ismt.c:532:3: warning: format '%llX' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Thanks, applied to next.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] i2c: fix i2c-ismt.c printk format warning
@ 2013-02-15 19:08 Neil Horman
0 siblings, 0 replies; 3+ messages in thread
From: Neil Horman @ 2013-02-15 19:08 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: bill.e.brown-ral2JQCrhuEAvxtiuMwx3w, khali-PUYAD+kWke1g9hUCZPvPmw,
seth.heasley-ral2JQCrhuEAvxtiuMwx3w,
w.sang-bIcnvbaLZ9MEGnE8C9+IrQ
>Fix printk format warning. dma_addr_t can be 32-bit or 64-bit,
>so cast it to long long for printing. This also matches the
>printk format specifier that is already used.
>
>drivers/i2c/busses/i2c-ismt.c:532:3: warning: format '%llX' expects argument of type \
>'long long unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat]
>
>Signed-off-by: Randy Dunlap <rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
>Cc: Bill E. Brown <bill.e.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
>Cc: Seth Heasley <seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>Cc: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
>Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
>Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Acked-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-15 19:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130215184255.5ba8a085004f4aadb9faf82c@canb.auug.org.au>
2013-02-15 18:51 ` [PATCH -next] i2c: fix i2c-ismt.c printk format warning Randy Dunlap
2013-02-15 19:48 ` Wolfram Sang
2013-02-15 19:08 Neil Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).