From mboxrd@z Thu Jan 1 00:00:00 1970 From: Li Zefan Subject: Re: [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API Date: Fri, 24 May 2013 11:42:23 +0800 Message-ID: <519EE19F.3000306@huawei.com> References: <1369310408-10348-1-git-send-email-libo.chen@huawei.com> <519EDFFC.5020308@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <519EDFFC.5020308-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gu Zheng Cc: Libo Chen , wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, sonic.zhang-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On 2013/5/24 11:35, Gu Zheng wrote: > Hi Libo, > I think you can merge patch 1/3 and 2/3, they do the same thing that using devm_* API to simplify > and make the code clean, and the additional goal is it also can fix a bug. nope. they should be separated. > Besides, maybe you need to > change the title and make it clear and self-described. >