[PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

[PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

[Santosh Shilimkar]

Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These
couple of patches makes it possible to select the I2C_DAVINCI on
Keystone SOCs.

Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>

Santosh Shilimkar (2):
  i2c: davinci: remove useless mach/hardware include
  i2c: davinci: Allow i2c driver available for keystone platforms

 drivers/i2c/busses/Kconfig       |    2 +-
 drivers/i2c/busses/i2c-davinci.c |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

-- 
1.7.9.5

[PATCH 1/2] i2c: davinci: remove useless mach/hardware include

[Santosh Shilimkar]

This driver no longer uses definitions from mach/hardware.h.
On the other hand, including this header breaks this driver
on non-davinci platforms which don't have such a header.

Fix it.

Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>

Signed-off-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
---
 drivers/i2c/busses/i2c-davinci.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index fa55605..ddaa2a3 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -41,7 +41,6 @@
 #include <linux/of_i2c.h>
 #include <linux/of_device.h>
 
-#include <mach/hardware.h>
 #include <linux/platform_data/i2c-davinci.h>
 
 /* ----- global defines ----------------------------------------------- */
-- 
1.7.9.5

Re: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include

[Sekhar Nori]

On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote:
> This driver no longer uses definitions from mach/hardware.h.
> On the other hand, including this header breaks this driver
> on non-davinci platforms which don't have such a header.
> 
> Fix it.
> 
> Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>

Acked-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>

One minor nit:

> ---
>  drivers/i2c/busses/i2c-davinci.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index fa55605..ddaa2a3 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -41,7 +41,6 @@
>  #include <linux/of_i2c.h>
>  #include <linux/of_device.h>
>  

You can now remove this empty line too.

Thanks,
Sekhar

> -#include <mach/hardware.h>
>  #include <linux/platform_data/i2c-davinci.h>
>  
>  /* ----- global defines ----------------------------------------------- */
> 

Re: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include

[Santosh Shilimkar]

On Thursday 25 July 2013 05:40 AM, Sekhar Nori wrote:
> On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote:
>> This driver no longer uses definitions from mach/hardware.h.
>> On the other hand, including this header breaks this driver
>> on non-davinci platforms which don't have such a header.
>>
>> Fix it.
>>
>> Cc: Sekhar Nori <nsekhar@ti.com>
>> Cc: Wolfram Sang <wsa@the-dreams.de>
>>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> 
> Acked-by: Sekhar Nori <nsekhar@ti.com>
> 
> One minor nit:
> 
>> ---
>>  drivers/i2c/busses/i2c-davinci.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
>> index fa55605..ddaa2a3 100644
>> --- a/drivers/i2c/busses/i2c-davinci.c
>> +++ b/drivers/i2c/busses/i2c-davinci.c
>> @@ -41,7 +41,6 @@
>>  #include <linux/of_i2c.h>
>>  #include <linux/of_device.h>
>>  
> 
> You can now remove this empty line too.
> 
Yes. Updated patch below with your ack added.

Regards,
Santosh

>From d7ae1c488ebae19028f33abff76c4d684271a7fb Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Tue, 23 Jul 2013 15:40:46 -0400
Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include

This driver no longer uses definitions from mach/hardware.h.
On the other hand, including this header breaks this driver
on non-davinci platforms which don't have such a header.

Fix it.


Cc: Wolfram Sang <wsa@the-dreams.de>

Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 drivers/i2c/busses/i2c-davinci.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index fa55605..5898df3 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -40,8 +40,6 @@
 #include <linux/gpio.h>
 #include <linux/of_i2c.h>
 #include <linux/of_device.h>
-
-#include <mach/hardware.h>
 #include <linux/platform_data/i2c-davinci.h>
 
 /* ----- global defines ----------------------------------------------- */
-- 
1.7.9.5

Re: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1855 bytes --]

On Thu, Jul 25, 2013 at 04:59:25PM -0400, Santosh Shilimkar wrote:
> On Thursday 25 July 2013 05:40 AM, Sekhar Nori wrote:
> > On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote:
> >> This driver no longer uses definitions from mach/hardware.h.
> >> On the other hand, including this header breaks this driver
> >> on non-davinci platforms which don't have such a header.
> >>
> >> Fix it.
> >>
> >> Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> >> Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> >>
> >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
> > 
> > Acked-by: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> > 
> > One minor nit:
> > 
> >> ---
> >>  drivers/i2c/busses/i2c-davinci.c |    1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> >> index fa55605..ddaa2a3 100644
> >> --- a/drivers/i2c/busses/i2c-davinci.c
> >> +++ b/drivers/i2c/busses/i2c-davinci.c
> >> @@ -41,7 +41,6 @@
> >>  #include <linux/of_i2c.h>
> >>  #include <linux/of_device.h>
> >>  
> > 
> > You can now remove this empty line too.
> > 
> Yes. Updated patch below with your ack added.
> 
> Regards,
> Santosh
> 
> From d7ae1c488ebae19028f33abff76c4d684271a7fb Mon Sep 17 00:00:00 2001
> From: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
> Date: Tue, 23 Jul 2013 15:40:46 -0400
> Subject: [PATCH 1/2] i2c: davinci: remove useless mach/hardware include
> 
> This driver no longer uses definitions from mach/hardware.h.
> On the other hand, including this header breaks this driver
> on non-davinci platforms which don't have such a header.
> 
> Fix it.

Applied to for-next, thanks! Please send a proper V2 in a seperate
message next time.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

[Santosh Shilimkar]

Wolfram, Sekhar, 

On Wednesday 24 July 2013 08:28 PM, Santosh Shilimkar wrote:
> Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These
> couple of patches makes it possible to select the I2C_DAVINCI on
> Keystone SOCs.
> 
> Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> 
> Santosh Shilimkar (2):
>   i2c: davinci: remove useless mach/hardware include
>   i2c: davinci: Allow i2c driver available for keystone platforms
> 
Who is queuing up these patches ?

regards,
Santosh

Re: [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

[Wolfram Sang]

On Fri, Aug 09, 2013 at 04:09:34PM -0400, Santosh Shilimkar wrote:
> Wolfram, Sekhar, 
> 
> On Wednesday 24 July 2013 08:28 PM, Santosh Shilimkar wrote:
> > Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These
> > couple of patches makes it possible to select the I2C_DAVINCI on
> > Keystone SOCs.
> > 
> > Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> > Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> > 
> > Santosh Shilimkar (2):
> >   i2c: davinci: remove useless mach/hardware include
> >   i2c: davinci: Allow i2c driver available for keystone platforms
> > 
> Who is queuing up these patches ?

I can pick them. Do they depend on something?

RE: [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

[Shilimkar, Santosh]

(Sorry for top posting ..)

No dependency so feel free to pick and merge them appropriately.

Regards,
Santosh
________________________________________
From: Wolfram Sang [wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org]
Sent: Sunday, August 11, 2013 5:53 AM
To: Shilimkar, Santosh
Cc: Nori, Sekhar; linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 0/2] i2c: davinci: Couple of patches to make i2c usable on Keystone SOCs

On Fri, Aug 09, 2013 at 04:09:34PM -0400, Santosh Shilimkar wrote:
> Wolfram, Sekhar,
>
> On Wednesday 24 July 2013 08:28 PM, Santosh Shilimkar wrote:
> > Keystone SOCs uses the same I2C IP as available on DaVinci SOCs. These
> > couple of patches makes it possible to select the I2C_DAVINCI on
> > Keystone SOCs.
> >
> > Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> > Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> >
> > Santosh Shilimkar (2):
> >   i2c: davinci: remove useless mach/hardware include
> >   i2c: davinci: Allow i2c driver available for keystone platforms
> >
> Who is queuing up these patches ?

I can pick them. Do they depend on something?

[PATCH 2/2] i2c: davinci: Allow i2c driver available for keystone platforms

[Santosh Shilimkar]

Keystone SOCs uses the same I2C IP as available on DaVinci SOCs.
Update the config so that ARCH_KEYSTONE can use it.

Cc: Sekhar Nori <nsekhar@ti.com>
Cc: Wolfram Sang <wsa@the-dreams.de>

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index dc6dea6..fcdd321 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -385,7 +385,7 @@ config I2C_CPM
 
 config I2C_DAVINCI
 	tristate "DaVinci I2C driver"
-	depends on ARCH_DAVINCI
+	depends on ARCH_DAVINCI || ARCH_KEYSTONE
 	help
 	  Support for TI DaVinci I2C controller driver.
 
-- 
1.7.9.5

Re: [PATCH 2/2] i2c: davinci: Allow i2c driver available for keystone platforms

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

On Wed, Jul 24, 2013 at 08:28:19PM -0400, Santosh Shilimkar wrote:
> Keystone SOCs uses the same I2C IP as available on DaVinci SOCs.
> Update the config so that ARCH_KEYSTONE can use it.
> 
> Cc: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>
> Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]