From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: Maxime COQUELIN <maxime.coquelin@st.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee.jones@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <rob.herring@calxeda.com>,
Stephen GALLIMORE <stephen.gallimore@st.com>,
Stuart MENEFY <stuart.menefy@st.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller
Date: Thu, 17 Oct 2013 10:33:33 +0100 [thread overview]
Message-ID: <525FAEED.7030207@st.com> (raw)
In-Reply-To: <525F915D.9020501@st.com>
On 17/10/13 08:27, Maxime COQUELIN wrote:
> ...
>>> >> +
>>> >> +static struct of_device_id st_i2c_match[] = {
>>> >> + { .compatible = "st,comms-ssc-i2c", },
>> > the rules is to put the first soc that use the ip in the compatible
>> > as st,sti7100-scc-i2c
> Ok. There are no plans to upstream the SH4 platforms, it will only
> remains in stlinux.com.
> Maybe I can set the first ARM platform (STiH415)?
> That would give st,stih415-ssc-i2c.
NAK, for st,stih415-ssc-i2c naming.
IMO, this makes sense when the same IP integration done on different SOC
changes slightly/very differently.
But in this case the "comms" IP remains unchanged across all the SOCs.
I would still prefer "st,comms-ssc-i2c", allowing a single device driver
to match against several SoCs. ST "comms" IP it is integrated across all
the STi series of SoCs, so we don't want to add new entry in compatible
for every new SOC.
Thanks,
srini
>
> Thanks for the review,
> Maxime
>
>> >
next prev parent reply other threads:[~2013-10-17 9:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 12:46 [PATCH v5 0/4] Add I2C support to ST SoCs Maxime COQUELIN
2013-10-14 12:46 ` [PATCH v5 1/4] i2c: busses: i2c-st: Add ST I2C controller Maxime COQUELIN
2013-10-16 15:14 ` Jean-Christophe PLAGNIOL-VILLARD
[not found] ` <20131016151419.GA14104-HVbc7XotTAhnXn40ka+A6Q@public.gmane.org>
2013-10-17 7:27 ` Maxime COQUELIN
2013-10-17 9:33 ` srinivas kandagatla [this message]
[not found] ` <525FAEED.7030207-qxv4g6HH51o@public.gmane.org>
2013-10-17 14:19 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-17 14:30 ` srinivas kandagatla
[not found] ` <525FF498.3060202-qxv4g6HH51o@public.gmane.org>
2013-10-17 14:49 ` Lucas Stach
[not found] ` <1382021369.4093.44.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2013-10-18 8:22 ` srinivas kandagatla
2013-10-28 15:02 ` Maxime Coquelin
[not found] ` <526E7C8C.8080603-qxv4g6HH51o@public.gmane.org>
2013-11-01 12:50 ` srinivas kandagatla
2013-10-17 15:53 ` Lee Jones
2013-10-17 16:09 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-17 14:16 ` Jean-Christophe PLAGNIOL-VILLARD
2013-10-17 16:48 ` Maxime COQUELIN
2013-10-28 19:25 ` Kumar Gala
2013-10-29 13:19 ` Maxime Coquelin
[not found] ` <526FB5FF.2060908-qxv4g6HH51o@public.gmane.org>
2013-10-29 15:49 ` Kumar Gala
2013-11-01 11:16 ` Wolfram Sang
2013-11-04 14:28 ` Maxime Coquelin
2013-10-14 12:46 ` [PATCH v5 3/4] ARM: STi: Supply I2C configuration to STiH415 SoC Maxime COQUELIN
[not found] ` <1381754813-4679-1-git-send-email-maxime.coquelin-qxv4g6HH51o@public.gmane.org>
2013-10-14 12:46 ` [PATCH v5 2/4] ARM: STi: Supply I2C configuration to STiH416 SoC Maxime COQUELIN
2013-10-14 12:46 ` [PATCH v5 4/4] ARM: STi: Add I2C config to B2000 and B2020 boards Maxime COQUELIN
2013-10-16 14:54 ` [PATCH v5 0/4] Add I2C support to ST SoCs Maxime COQUELIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525FAEED.7030207@st.com \
--to=srinivas.kandagatla@st.com \
--cc=devicetree@vger.kernel.org \
--cc=gabriel.fernandez@st.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.coquelin@st.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=stephen.gallimore@st.com \
--cc=stuart.menefy@st.com \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).