From: Nicolas Ferre <nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: boris brezillon
<b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>,
ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: at91: sama5d3: reduce TWI internal clock frequency
Date: Fri, 22 Nov 2013 16:11:01 +0100 [thread overview]
Message-ID: <528F7405.9050901@atmel.com> (raw)
In-Reply-To: <528F71BD.2080407-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
On 22/11/2013 16:01, boris brezillon :
> Hi Ludovic,
>
> On 22/11/2013 15:07, ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org wrote:
>> From: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>>
>> There are still I2C unexpected behaviors which are solved by reducing TWI
>> internal frequency.
>
> I guess I should do the same for the dt version of sama5 clks.
> Nicolas, what do you think ?
Yes, you can queue these modification on top of your "CCF related fixes"
branch.
Bye,
>> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> #3.10+
>> Signed-off-by: Ludovic Desroches <ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
>> ---
>> arch/arm/mach-at91/sama5d3.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/mach-at91/sama5d3.c b/arch/arm/mach-at91/sama5d3.c
>> index 4012797..4ee0de5 100644
>> --- a/arch/arm/mach-at91/sama5d3.c
>> +++ b/arch/arm/mach-at91/sama5d3.c
>> @@ -95,19 +95,19 @@ static struct clk twi0_clk = {
>> .name = "twi0_clk",
>> .pid = SAMA5D3_ID_TWI0,
>> .type = CLK_TYPE_PERIPHERAL,
>> - .div = AT91_PMC_PCR_DIV2,
>> + .div = AT91_PMC_PCR_DIV8,
>> };
>> static struct clk twi1_clk = {
>> .name = "twi1_clk",
>> .pid = SAMA5D3_ID_TWI1,
>> .type = CLK_TYPE_PERIPHERAL,
>> - .div = AT91_PMC_PCR_DIV2,
>> + .div = AT91_PMC_PCR_DIV8,
>> };
>> static struct clk twi2_clk = {
>> .name = "twi2_clk",
>> .pid = SAMA5D3_ID_TWI2,
>> .type = CLK_TYPE_PERIPHERAL,
>> - .div = AT91_PMC_PCR_DIV2,
>> + .div = AT91_PMC_PCR_DIV8,
>> };
>> static struct clk mmc0_clk = {
>> .name = "mci0_clk",
>>
>
>
>
--
Nicolas Ferre
prev parent reply other threads:[~2013-11-22 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 14:07 [PATCH] ARM: at91: sama5d3: reduce TWI internal clock frequency ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w
[not found] ` <1385129228-11225-1-git-send-email-ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-11-22 14:33 ` Wolfram Sang
2013-11-22 14:51 ` Ludovic Desroches
[not found] ` <20131122145141.GB30749@ludovic.desroches@atmel.com>
[not found] ` <20131122145141.GB30749-tOglhBvtKaELqBSMlTbpHvU/3Eu2kcEP@public.gmane.org@atmel.com>
2013-11-22 14:58 ` Wolfram Sang
2013-11-22 15:07 ` Ludovic Desroches
[not found] ` <20131122150734.GC30749@ludovic.desroches@atmel.com>
[not found] ` <20131122150734.GC30749-tOglhBvtKaELqBSMlTbpHvU/3Eu2kcEP@public.gmane.org@atmel.com>
2013-11-22 15:09 ` Nicolas Ferre
2013-11-22 15:01 ` boris brezillon
[not found] ` <528F71BD.2080407-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org>
2013-11-22 15:11 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528F7405.9050901@atmel.com \
--to=nicolas.ferre-aife0yeh4naavxtiumwx3w@public.gmane.org \
--cc=b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox