* [PATCH] Documentation: i2c: Remove obsolete example
@ 2013-11-28 15:02 Helia Correia
[not found] ` <52975B11.2090006-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Helia Correia @ 2013-11-28 15:02 UTC (permalink / raw)
To: wsa-z923LK4zBo2bacvFa/9K2g
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
jerome.blin-ral2JQCrhuEAvxtiuMwx3w, Correia, Helia
Documentation/i2c/fault-codes illustrates EINVAL error code
as follows:
"One example would be a driver trying an SMBus Block Write
with block size outside the range of 1-32 bytes."
However, the actual implementation of i2c subsystem truncates
data length to be 32 bytes.
Hence this example cannot happen anymore, and since it's obsolete,
let's simply remove it from Documentation/i2c/fault-codes.
Signed-off-by: Helia Correia <helia.correia-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
Documentation/i2c/fault-codes | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Documentation/i2c/fault-codes b/Documentation/i2c/fault-codes
index 045765c0b9b5..47c25abb7d52 100644
--- a/Documentation/i2c/fault-codes
+++ b/Documentation/i2c/fault-codes
@@ -64,9 +64,6 @@ EINVAL
detected before any I/O operation was started. Use a more
specific fault code when you can.
- One example would be a driver trying an SMBus Block Write
- with block size outside the range of 1-32 bytes.
-
EIO
This rather vague error means something went wrong when
performing an I/O operation. Use a more specific fault
--
1.8.1.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation: i2c: Remove obsolete example
[not found] ` <52975B11.2090006-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
@ 2014-01-09 22:00 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2014-01-09 22:00 UTC (permalink / raw)
To: Helia Correia
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA,
jerome.blin-ral2JQCrhuEAvxtiuMwx3w, Correia, Helia
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Thu, Nov 28, 2013 at 04:02:41PM +0100, Helia Correia wrote:
> Documentation/i2c/fault-codes illustrates EINVAL error code
> as follows:
>
> "One example would be a driver trying an SMBus Block Write
> with block size outside the range of 1-32 bytes."
>
> However, the actual implementation of i2c subsystem truncates
> data length to be 32 bytes.
> Hence this example cannot happen anymore, and since it's obsolete,
> let's simply remove it from Documentation/i2c/fault-codes.
>
> Signed-off-by: Helia Correia <helia.correia-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
Applied to for-next, thanks! Although, it can still happen that length
is 0... we should probably check for this in the core, too. Anyway, the
example is not the best, so it can go.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-09 22:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-28 15:02 [PATCH] Documentation: i2c: Remove obsolete example Helia Correia
[not found] ` <52975B11.2090006-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2014-01-09 22:00 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).